From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dan Williams <dan.j.williams@intel.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Andy Green <andy.green@linaro.org>,
Peter Griffin <peter.griffin@linaro.org>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: k3dma: use correct format string for debug output
Date: Wed, 7 Sep 2016 13:42:52 +0530 [thread overview]
Message-ID: <20160907081251.GW9355@localhost> (raw)
In-Reply-To: <20160906131804.1961750-1-arnd@arndb.de>
On Tue, Sep 06, 2016 at 03:17:49PM +0200, Arnd Bergmann wrote:
> The newly added k3_dma_prep_dma_cyclic function has some debug output
> that uses incorrect typecasts, some of which cause a warning like:
>
> drivers/dma/k3dma.c: In function 'k3_dma_prep_dma_cyclic':
> drivers/dma/k3dma.c:589:671: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> In general, we have to print 'dma_addr_t' values using special
> '%pad' format to get the correct behavior on kernels that have
> a 64-bit dma_addr_t type but 32-bit pointers.
>
> Similarly, printing size_t values should be done using the %z
> modifier to get the correct behavior on 64-bit kernels.
Applied both, thanks
--
~Vinod
prev parent reply other threads:[~2016-09-07 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 13:17 [PATCH] dmaengine: k3dma: use correct format string for debug output Arnd Bergmann
2016-09-07 8:12 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907081251.GW9355@localhost \
--to=vinod.koul@intel.com \
--cc=andy.green@linaro.org \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=yongjun_wei@trendmicro.com.cn \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox