From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756862AbcIGIEp (ORCPT ); Wed, 7 Sep 2016 04:04:45 -0400 Received: from mga09.intel.com ([134.134.136.24]:14589 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756521AbcIGIEl (ORCPT ); Wed, 7 Sep 2016 04:04:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; d="scan'208";a="5370246" Date: Wed, 7 Sep 2016 13:42:52 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Dan Williams , Zhangfei Gao , John Stultz , Andy Green , Peter Griffin , Wei Yongjun , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: k3dma: use correct format string for debug output Message-ID: <20160907081251.GW9355@localhost> References: <20160906131804.1961750-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160906131804.1961750-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2016 at 03:17:49PM +0200, Arnd Bergmann wrote: > The newly added k3_dma_prep_dma_cyclic function has some debug output > that uses incorrect typecasts, some of which cause a warning like: > > drivers/dma/k3dma.c: In function 'k3_dma_prep_dma_cyclic': > drivers/dma/k3dma.c:589:671: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] > > In general, we have to print 'dma_addr_t' values using special > '%pad' format to get the correct behavior on kernels that have > a 64-bit dma_addr_t type but 32-bit pointers. > > Similarly, printing size_t values should be done using the %z > modifier to get the correct behavior on 64-bit kernels. Applied both, thanks -- ~Vinod