From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030206AbcIGM7L (ORCPT ); Wed, 7 Sep 2016 08:59:11 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38872 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932705AbcIGM7J (ORCPT ); Wed, 7 Sep 2016 08:59:09 -0400 Date: Wed, 7 Sep 2016 14:59:03 +0200 From: Jiri Pirko To: Jacek Anaszewski Cc: vadimp@mellanox.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, michaelsh@mellanox.com Subject: Re: [patch] leds: add driver for Mellanox systems leds Message-ID: <20160907125903.GA8088@nanopsycho> References: <1473255323-191745-1-git-send-email-vadimp@mellanox.com> <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Sep 07, 2016 at 02:49:00PM CEST, j.anaszewski@samsung.com wrote: >Hi Vadim, > >On 09/07/2016 03:35 PM, vadimp@mellanox.com wrote: >> From: Vadim Pasternak >> >> This makes it possible to create a set of LEDs for Mellanox systems: >> "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", >> "msb7800", "msn2740", "msn2100". >> >> Driver obtains led devices according to system configuration, provided >> through system DMI data, like fan1:green, fan1:red and creates devices in >> form: "devicename:colour:function". >> >> led setting is controlled through on board CPLD Lattice device. >> For setting particular led off, solid, >> blink (blink requires ledtrig-timer module): >> echo 0 > /sys/class/leds/status\:green/brightness >> echo 1 > /sys/class/leds/status\:green/brightness >> echo timer > /sys/class/leds/status\:green/trigger >> > >Thanks for the update, will review it soon. > >One important detail - please update patch version each time >you're sending a new one, like [PATCH v2]. Also a brief history of changes made would help. > >-- >Best regards, >Jacek Anaszewski