From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756478AbcIHCbr (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 22:31:47 -0400
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:43119 "EHLO
        lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751606AbcIHCbi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 22:31:38 -0400
X-Original-SENDERIP: 156.147.1.127
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 165.244.98.150
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.223.161
X-Original-MAILFROM: minchan@kernel.org
Date: Thu, 8 Sep 2016 11:31:34 +0900
From: Minchan Kim <minchan@kernel.org>
To: Andreas Mohr <andi@lisas.de>
CC: Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC] zram: support page-based parallel write
Message-ID: <20160908023134.GA21691@bbox>
References: <1473146657-4402-1-git-send-email-minchan@kernel.org>
 <20160906082220.GA2751@rhlx01.hs-esslingen.de>
MIME-Version: 1.0
In-Reply-To: <20160906082220.GA2751@rhlx01.hs-esslingen.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/09/08 11:31:34,
        Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/09/08 11:31:34,
        Serialize complete at 2016/09/08 11:31:34
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

On Tue, Sep 06, 2016 at 10:22:20AM +0200, Andreas Mohr wrote:
> On Tue, Sep 06, 2016 at 04:24:17PM +0900, Minchan Kim wrote:
> > @@ -1464,6 +1908,9 @@ static int __init zram_init(void)
> >  		num_devices--;
> >  	}
> >  
> > +	if (create_workers())
> > +		goto out_error;
> > +
> >  	return 0;
> >  
> >  out_error:
> > @@ -1474,6 +1921,7 @@ static int __init zram_init(void)
> >  static void __exit zram_exit(void)
> >  {
> >  	destroy_devices();
> > +	destroy_workers();
> >  }
> 
> 
> Asymmetry --> "BUG".
> 
> ...right?

destory_workers checks workers list so if it's empty, it doesn
nothing. Anyway, I am chaning thread management model now so
it should be changed, too. :)

> 
> (I have to admit that current implementation structure
> is not easy to follow,
> thus I'm not fully sure)
> 
> 
> Thanks for working in this important area!

Thanks for the interest.