From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbcIHH3X (ORCPT ); Thu, 8 Sep 2016 03:29:23 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36816 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751667AbcIHH3W (ORCPT ); Thu, 8 Sep 2016 03:29:22 -0400 Date: Thu, 8 Sep 2016 09:29:19 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni Subject: Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Message-ID: <20160908072919.GE8913@lukather> References: <20160906144620.6322-1-maxime.ripard@free-electrons.com> <20160906144620.6322-3-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d8Lz2Tf5e5STOWUP" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --d8Lz2Tf5e5STOWUP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 06, 2016 at 11:16:33PM +0800, Chen-Yu Tsai wrote: > On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard > wrote: > > The A33 has a significantly different pipeline, with components that di= ffer > > too. > > > > Make sure we had compatible for them. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++= ++- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 ++++= +--- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 ++++= +++- > > 4 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.= txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index df8f4aeefe4c..bd3136a5cba5 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -26,7 +26,9 @@ TCON > > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > > > Required properties: > > - - compatible: value should be "allwinner,sun5i-a13-tcon". > > + - compatible: value must be either: > > + * allwinner,sun5i-a13-tcon > > + * allwinner,sun8i-a33-tcon > > - reg: base address and size of memory-mapped region > > - interrupts: interrupt associated to this IP > > - clocks: phandles to the clocks feeding the TCON. Three are needed: >=20 > You should probably put a note saying the A33 only needs 2 clocks. > You can keep my ack after fixing it. I did while applying, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --d8Lz2Tf5e5STOWUP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX0RNPAAoJEBx+YmzsjxAgDEoP/0BYftnQAHwyrlGr/hwBR7ZW xGhJIvIgwJp49pq3DYTFcetEk5bIiwf9fj1KUz3S0D8WdA6ckuI2hWVJsfbMT4/f yRUn90c9lOhc60poVQSXRX14LDfPGrqS7n9Wsh2MTJVzKcv7QQDjmnZB26r6ImYL SwASnvtxmWb4q6zNt85P91G1xE07FaRYxiAZKD10FDRp+fCYvzxXOo5Bht/pybt9 DjfIIP8OKLeak5iRplxKuur0Fzub5V2u55i/yKrf2V5HzjbDRg0+lKk1M9ZnDN1c qYNllbaIDe6g+AIzl6F2cOnLD/mBVDGbtFxoYCd1tdLXU7YB9KWMcZaIVaEt0Nlv fLCIZpjNz45gYbwml/LUJlYEfyOlyGIuPanHwB0n2Vz1Yms4WrIxMyxm59UrWlUs +nC7KtAmC4h2LydtEuEKn9wpm3wIPj5i98ZL3zUuqiKWSmzI8VcTmmh8MVoDqREK BeBa9O/JN9ForEZWI6BjzzckoRLGe3E69bWy+tsWNvDmj51USBNQoZAVmmJnmqRe wkhBLN7tS78Btuh1dcO4R4G9UCxswHNztcuYGw88XQm8dRXbdf6ncW5FJXJyWHEC DM5hPhDk2iUb4wRJ2cx8N9g2NAxYYZS0t1AWU3CRaFa5ReteUAdPHnSMtFNBs1KA +rmNi+Z4dv23bFrqVCzg =Q+sT -----END PGP SIGNATURE----- --d8Lz2Tf5e5STOWUP--