From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759246AbcIHLAW (ORCPT ); Thu, 8 Sep 2016 07:00:22 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36266 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbcIHLAU (ORCPT ); Thu, 8 Sep 2016 07:00:20 -0400 Date: Thu, 8 Sep 2016 12:02:09 +0100 From: Lee Jones To: loic pallardy Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@stlinux.com Subject: Re: [PATCH v2 12/19] remoteproc: core: Add vdev support and force mode to resource amending function Message-ID: <20160908110209.GQ4921@dell> References: <1472676622-32533-1-git-send-email-loic.pallardy@st.com> <1472676622-32533-13-git-send-email-loic.pallardy@st.com> <20160908084805.GL4921@dell> <45e0d198-b913-ee2c-df00-b1ba8e1a179a@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <45e0d198-b913-ee2c-df00-b1ba8e1a179a@st.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Sep 2016, loic pallardy wrote: > > > On 09/08/2016 10:48 AM, Lee Jones wrote: > > On Wed, 31 Aug 2016, Loic Pallardy wrote: > > > > > This patch proposes diverse updates to rproc_update_resource_table_entry > > > function: > > > - rename rproc_update_resource_table_entry to __update_rsc_tbl_entry to > > > have shorter function name. > > > - add RSC_VDEV support > > > - add force mode resource even if resource already fixed on firmware side. > > > > > > Signed-off-by: Loic Pallardy > > > --- > > > drivers/remoteproc/remoteproc_core.c | 27 ++++++++++++++++++++++----- > > > 1 file changed, 22 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > > > index 30e9c70..aff1a00 100644 > > > --- a/drivers/remoteproc/remoteproc_core.c > > > +++ b/drivers/remoteproc/remoteproc_core.c > > > @@ -1027,13 +1027,15 @@ static int __verify_rsc_tbl_entry(struct rproc *rproc, > > > return -EINVAL; > > > } > > > > > > -static int rproc_update_resource_table_entry(struct rproc *rproc, > > > +static int __update_rsc_tbl_entry(struct rproc *rproc, > > > > Unless the name is unruly, (which I don't think it is, you're still > > having to line wrap at the call site), I tend to go for clarity over > > brevity. > It was only to have reasonable line length. I can keept original name and > see impact on rest of the code. Reasonable line length is 80. This line was 65. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog