From: Oleg Nesterov <oleg@redhat.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: lkp@01.org, linux-kernel@vger.kernel.org,
Neil Brown <neilb@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Bart Van Assche <bvanassche@acm.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [sched/wait] 02ae2b22bd: WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might_sleep+0x6e/0x90
Date: Thu, 8 Sep 2016 14:03:00 +0200 [thread overview]
Message-ID: <20160908120300.GA11135@redhat.com> (raw)
In-Reply-To: <57d0ed74./RdHPAg3uO0deEfh%xiaolong.ye@intel.com>
On 09/08, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> https://github.com/0day-ci/linux Oleg-Nesterov/sched-wait-fix-and-then-kill-abort_exclusive_wait/20160907-145024
> commit 02ae2b22bd2a42c4e4054563b139a541ba67a43e ("sched/wait: avoid abort_exclusive_wait() in ___wait_event()")
Thanks!
> [ 30.775242] kill 958 cat /proc/kmsg
> [ 30.775242] wait for background monitors: 959 962 oom-killer nfs-hang
> [ 32.078512] ------------[ cut here ]------------
> [ 32.080657] WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might_sleep+0x6e/0x90
> [ 32.084787] do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81107e0d>] prepare_to_wait_event+0xad/0x120
Because I am stupid. With my change prepare_to_wait_event() does
set_current_state(state) even on failure.
Thanks a lot, I'll send V2.
Oleg.
prev parent reply other threads:[~2016-09-08 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 4:47 [sched/wait] 02ae2b22bd: WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might_sleep+0x6e/0x90 kernel test robot
2016-09-08 12:03 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908120300.GA11135@redhat.com \
--to=oleg@redhat.com \
--cc=bvanassche@acm.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).