From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965259AbcIHMDG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Sep 2016 08:03:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59346 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S936013AbcIHMDF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Sep 2016 08:03:05 -0400
Date: Thu, 8 Sep 2016 14:03:00 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: lkp@01.org, linux-kernel@vger.kernel.org, Neil Brown <neilb@suse.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Bart Van Assche <bvanassche@acm.org>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [sched/wait]  02ae2b22bd: WARNING: CPU: 0 PID: 958 at
 kernel/sched/core.c:7610 __might_sleep+0x6e/0x90
Message-ID: <20160908120300.GA11135@redhat.com>
References: <57d0ed74./RdHPAg3uO0deEfh%xiaolong.ye@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <57d0ed74./RdHPAg3uO0deEfh%xiaolong.ye@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 08 Sep 2016 12:03:04 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/08, kernel test robot wrote:
>
> FYI, we noticed the following commit:
>
> https://github.com/0day-ci/linux Oleg-Nesterov/sched-wait-fix-and-then-kill-abort_exclusive_wait/20160907-145024
> commit 02ae2b22bd2a42c4e4054563b139a541ba67a43e ("sched/wait: avoid abort_exclusive_wait() in ___wait_event()")

Thanks!


> [   30.775242] kill 958 cat /proc/kmsg
> [   30.775242] wait for background monitors: 959 962 oom-killer nfs-hang
> [   32.078512] ------------[ cut here ]------------
> [   32.080657] WARNING: CPU: 0 PID: 958 at kernel/sched/core.c:7610 __might_sleep+0x6e/0x90
> [   32.084787] do not call blocking ops when !TASK_RUNNING; state=1 set at [<ffffffff81107e0d>] prepare_to_wait_event+0xad/0x120

Because I am stupid. With my change prepare_to_wait_event() does
set_current_state(state) even on failure.

Thanks a lot, I'll send V2.

Oleg.