From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mylene Josserand <mylene.josserand@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Alexander Kaplan <alex@nextthing.co>
Subject: Re: [PATCH v3 3/3] ARM: dts: gr8: Add support for the GR8 evaluation board
Date: Thu, 8 Sep 2016 14:34:23 +0200 [thread overview]
Message-ID: <20160908123423.GP8913@lukather> (raw)
In-Reply-To: <CAGb2v648hLSKsCv6HjaYGUPtvMRGqFC5N-ST4Tp3qsNTw_igmQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Thu, Sep 08, 2016 at 06:34:55PM +0800, Chen-Yu Tsai wrote:
> > +&i2c1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c1_pins_a>;
> > + status = "okay";
> > +
> > + pcf8563: rtc@51 {
> > + compatible = "phg,pcf8563";
> > + reg = <0x51>;
> > + };
> > +
> > + wm8978: codec@1a {
>
> I think these should be ordered by address? Otherwise
Yeah, sorry, I don't know how to count anymore....
Thanks, I fixed it while applying.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-09-08 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 10:26 [PATCH v3 0/4] Introduce NextThing GR8 support Maxime Ripard
2016-09-08 10:26 ` [PATCH v3 1/3] ARM: sunxi: Support the Nextthing GR8 Maxime Ripard
2016-09-08 10:26 ` [PATCH v3 2/3] ARM: dts: Add NextThing GR8 dtsi Maxime Ripard
2016-09-08 10:37 ` Chen-Yu Tsai
2016-09-08 10:26 ` [PATCH v3 3/3] ARM: dts: gr8: Add support for the GR8 evaluation board Maxime Ripard
2016-09-08 10:34 ` Chen-Yu Tsai
2016-09-08 12:34 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908123423.GP8913@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alex@nextthing.co \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mylene.josserand@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox