From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] perf/powerpc: Fix build-test failure
Date: Thu, 8 Sep 2016 13:30:27 -0300 [thread overview]
Message-ID: <20160908163027.GC4801@kernel.org> (raw)
In-Reply-To: <57D03452.6060402@linux.vnet.ibm.com>
Em Wed, Sep 07, 2016 at 09:07:54PM +0530, Ravi Bangoria escreveu:
> Hi Arnaldo,
>
> Can you please pick up this.
>
> -Ravi
>
> On Wednesday 31 August 2016 01:33 PM, Ravi Bangoria wrote:
> > 'make -C tools/perf build-test' is failing with below log for poewrpc.
> >
> > In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0,
> > from util/cpumap.h:8,
> > from util/env.c:1:
> > /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56:
> > fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory
> > compilation terminated.
> >
> > I bisected it and found it's failing from commit ad430729ae00 ("Remove:
> > kernel unistd*h files from perf's MANIFEST, not used").
The above commit ad430729ae00 is broken for ppc, as we were still
referencing that kernel file, thanks for spotting this, adding your
patch with a Fixes ad430729ae00.
- Arnaldo
> > Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included
> > only for powerpc in tools/perf/perf-sys.h.
> >
> > By looking closly at commit history, I found little weird thing:
> >
> > Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build
> > error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h'
> >
> > Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI
> > disintegration applied") removes all arch specific 'uapi/asm/unistd.h'
> > for all archs and adds generic <asm/unistd.h>.
> >
> > Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again
> > includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this
> > happened as this change is not part of commit also.
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> > ---
> > tools/perf/perf-sys.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h
> > index 7ed72a4..e4b717e 100644
> > --- a/tools/perf/perf-sys.h
> > +++ b/tools/perf/perf-sys.h
> > @@ -20,7 +20,6 @@
> > #endif
> >
> > #ifdef __powerpc__
> > -#include "../../arch/powerpc/include/uapi/asm/unistd.h"
> > #define CPUINFO_PROC {"cpu"}
> > #endif
> >
next prev parent reply other threads:[~2016-09-08 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 8:03 [PATCH] perf/powerpc: Fix build-test failure Ravi Bangoria
2016-09-07 15:37 ` Ravi Bangoria
2016-09-08 16:30 ` Arnaldo Carvalho de Melo [this message]
2016-09-09 5:54 ` [tip:perf/core] perf powerpc: " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908163027.GC4801@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).