From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932173AbcIHQai (ORCPT ); Thu, 8 Sep 2016 12:30:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:46334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932809AbcIHQag (ORCPT ); Thu, 8 Sep 2016 12:30:36 -0400 Date: Thu, 8 Sep 2016 13:30:27 -0300 From: Arnaldo Carvalho de Melo To: Ravi Bangoria Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com Subject: Re: [PATCH] perf/powerpc: Fix build-test failure Message-ID: <20160908163027.GC4801@kernel.org> References: <1472630591-5089-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <57D03452.6060402@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57D03452.6060402@linux.vnet.ibm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 07, 2016 at 09:07:54PM +0530, Ravi Bangoria escreveu: > Hi Arnaldo, > > Can you please pick up this. > > -Ravi > > On Wednesday 31 August 2016 01:33 PM, Ravi Bangoria wrote: > > 'make -C tools/perf build-test' is failing with below log for poewrpc. > > > > In file included from /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf.h:15:0, > > from util/cpumap.h:8, > > from util/env.c:1: > > /tmp/tmp.3eEwmGlYaF/perf-4.8.0-rc4/tools/perf/perf-sys.h:23:56: > > fatal error: ../../arch/powerpc/include/uapi/asm/unistd.h: No such file or directory > > compilation terminated. > > > > I bisected it and found it's failing from commit ad430729ae00 ("Remove: > > kernel unistd*h files from perf's MANIFEST, not used"). The above commit ad430729ae00 is broken for ppc, as we were still referencing that kernel file, thanks for spotting this, adding your patch with a Fixes ad430729ae00. - Arnaldo > > Header file '../../arch/powerpc/include/uapi/asm/unistd.h' is included > > only for powerpc in tools/perf/perf-sys.h. > > > > By looking closly at commit history, I found little weird thing: > > > > Commit f2d9cae9ea9e ("perf powerpc: Use uapi/unistd.h to fix build > > error") replaced 'asm/unistd.h' with 'uapi/asm/unistd.h' > > > > Commit d2709c7ce4c5 ("perf: Make perf build for x86 with UAPI > > disintegration applied") removes all arch specific 'uapi/asm/unistd.h' > > for all archs and adds generic . > > > > Commit f0b9abfb0446 ("Merge branch 'linus' into perf/core") again > > includes 'uapi/asm/unistd.h' for powerpc. Don't know how exactly this > > happened as this change is not part of commit also. > > > > Signed-off-by: Ravi Bangoria > > --- > > tools/perf/perf-sys.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h > > index 7ed72a4..e4b717e 100644 > > --- a/tools/perf/perf-sys.h > > +++ b/tools/perf/perf-sys.h > > @@ -20,7 +20,6 @@ > > #endif > > > > #ifdef __powerpc__ > > -#include "../../arch/powerpc/include/uapi/asm/unistd.h" > > #define CPUINFO_PROC {"cpu"} > > #endif > >