From: Vinod Koul <vinod.koul@intel.com>
To: Hsin-Yu Chao <hychao@chromium.org>
Cc: smbarber@chromium.org, groeck@chromium.org,
Dan Williams <dan.j.williams@intel.com>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: pl330: Acquire dmac's spinlock in pl330_tx_status
Date: Fri, 9 Sep 2016 17:23:05 +0530 [thread overview]
Message-ID: <20160909115305.GQ9355@localhost> (raw)
In-Reply-To: <1471943815-30977-1-git-send-email-hychao@chromium.org>
On Tue, Aug 23, 2016 at 05:16:55PM +0800, Hsin-Yu Chao wrote:
> There is a racing when accessing dmac thread in pl330_tx_status that
> the pl330_update is handling active request at the same time and
> changing the status of descriptors. This could cause an invalid
> transferred count from BUSY descriptor added up to the residual number.
> Fix the bug by using the dmac's spinlock in pl330_tx_status to protect
> thread resources from changing.
> Note that the nested order of holding dmac's and dma_chan's spinlock is
> consistent with the rest of the driver: dma_chan first and then dmac,
> so it is safe from deadlock scenario.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2016-09-09 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:16 [PATCH] dmaengine: pl330: Acquire dmac's spinlock in pl330_tx_status Hsin-Yu Chao
2016-08-23 17:08 ` Guenter Roeck
2016-09-09 11:53 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909115305.GQ9355@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=hychao@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smbarber@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox