public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
@ 2016-09-07 16:38 Nick Warne
  2016-09-08  6:29 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Nick Warne @ 2016-09-07 16:38 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Greg Kroah-Hartman, linux-kernel

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function
‘intel_plane_obj_offset’: drivers/gpu/drm/i915/intel_display.c:2969:11:
warning: cast to pointer from integer of different size
[-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up.  Any reason why it hasn't in the latest 4.4.x
longterm tree?

Thanks,

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
  2016-09-07 16:38 drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer Nick Warne
@ 2016-09-08  6:29 ` Greg Kroah-Hartman
  2016-09-08 15:59   ` Nick Warne
  0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-08  6:29 UTC (permalink / raw)
  To: Nick Warne; +Cc: Daniel Vetter, linux-kernel

On Wed, Sep 07, 2016 at 05:38:52PM +0100, Nick Warne wrote:
> Hi Daniel,
> 
> kernel build 4.4.20 - I am still seeing this warning:
> 
> drivers/gpu/drm/i915/intel_display.c: In function
> ‘intel_plane_obj_offset’: drivers/gpu/drm/i915/intel_display.c:2969:11:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;
> 
> but according to here:
> 
> https://patchwork.kernel.org/patch/7897461/
> 
> this has been fixed up.  Any reason why it hasn't in the latest 4.4.x
> longterm tree?

What is the commit id that fixed this in Linus's tree?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
  2016-09-08  6:29 ` Greg Kroah-Hartman
@ 2016-09-08 15:59   ` Nick Warne
  2016-09-09 11:55     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Nick Warne @ 2016-09-08 15:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Daniel Vetter, linux-kernel

On Thu, 8 Sep 2016 08:29:37 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Wed, Sep 07, 2016 at 05:38:52PM +0100, Nick Warne wrote:
> > Hi Daniel,
> > 
> > kernel build 4.4.20 - I am still seeing this warning:
> > 
> > drivers/gpu/drm/i915/intel_display.c: In function
> > ‘intel_plane_obj_offset’:
> > drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to
> > pointer from integer of different size [-Wint-to-pointer-cast]
> > offset = (unsigned char *)vma->node.start;
> > 
> > but according to here:
> > 
> > https://patchwork.kernel.org/patch/7897461/
> > 
> > this has been fixed up.  Any reason why it hasn't in the latest
> > 4.4.x longterm tree?  
> 
> What is the commit id that fixed this in Linus's tree?

Took me a while to find it if this is it - a bit of a re-write in the
whole file I think:

https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Thanks,

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
  2016-09-08 15:59   ` Nick Warne
@ 2016-09-09 11:55     ` Greg Kroah-Hartman
  2016-09-09 12:55       ` Nick Warne
  2016-09-10 10:48       ` Nick Warne
  0 siblings, 2 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-09 11:55 UTC (permalink / raw)
  To: Nick Warne; +Cc: Daniel Vetter, linux-kernel

On Thu, Sep 08, 2016 at 04:59:53PM +0100, Nick Warne wrote:
> On Thu, 8 Sep 2016 08:29:37 +0200
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Sep 07, 2016 at 05:38:52PM +0100, Nick Warne wrote:
> > > Hi Daniel,
> > > 
> > > kernel build 4.4.20 - I am still seeing this warning:
> > > 
> > > drivers/gpu/drm/i915/intel_display.c: In function
> > > ‘intel_plane_obj_offset’:
> > > drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to
> > > pointer from integer of different size [-Wint-to-pointer-cast]
> > > offset = (unsigned char *)vma->node.start;
> > > 
> > > but according to here:
> > > 
> > > https://patchwork.kernel.org/patch/7897461/
> > > 
> > > this has been fixed up.  Any reason why it hasn't in the latest
> > > 4.4.x longterm tree?  
> > 
> > What is the commit id that fixed this in Linus's tree?
> 
> Took me a while to find it if this is it - a bit of a re-write in the
> whole file I think:
> 
> https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Ick, messy.

Why not just use 4.7?  Why are you stuck at 4.4?

And is this a real bug in 4.4 or just a build warning?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
  2016-09-09 11:55     ` Greg Kroah-Hartman
@ 2016-09-09 12:55       ` Nick Warne
  2016-09-10 10:48       ` Nick Warne
  1 sibling, 0 replies; 6+ messages in thread
From: Nick Warne @ 2016-09-09 12:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Daniel Vetter, linux-kernel

On Fri, 9 Sep 2016 13:55:45 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Sep 08, 2016 at 04:59:53PM +0100, Nick Warne wrote:
> > On Thu, 8 Sep 2016 08:29:37 +0200
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >   
> > > On Wed, Sep 07, 2016 at 05:38:52PM +0100, Nick Warne wrote:  
> > > > Hi Daniel,
> > > > 
> > > > kernel build 4.4.20 - I am still seeing this warning:
> > > > 
> > > > drivers/gpu/drm/i915/intel_display.c: In function
> > > > ‘intel_plane_obj_offset’:
> > > > drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to
> > > > pointer from integer of different size [-Wint-to-pointer-cast]
> > > > offset = (unsigned char *)vma->node.start;
> > > > 
> > > > but according to here:
> > > > 
> > > > https://patchwork.kernel.org/patch/7897461/
> > > > 
> > > > this has been fixed up.  Any reason why it hasn't in the latest
> > > > 4.4.x longterm tree?    
> > > 
> > > What is the commit id that fixed this in Linus's tree?  
> > 
> > Took me a while to find it if this is it - a bit of a re-write in
> > the whole file I think:
> > 
> > https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f  
> 
> Ick, messy.
> 
> Why not just use 4.7?  Why are you stuck at 4.4?

I only recently moved over to 4.4 from 3.18.x as it's longterm
support. I may try 4.7 over the weekend - or maybe even just use the
patchwork diff on my own local builds.

> And is this a real bug in 4.4 or just a build warning?

No, it's not a bug (that I have found or seen, anyway), just GCC
squinnying.

Thanks for your help, and sorry for the noise.

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer
  2016-09-09 11:55     ` Greg Kroah-Hartman
  2016-09-09 12:55       ` Nick Warne
@ 2016-09-10 10:48       ` Nick Warne
  1 sibling, 0 replies; 6+ messages in thread
From: Nick Warne @ 2016-09-10 10:48 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Daniel Vetter, linux-kernel

On Fri, 9 Sep 2016 13:55:45 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Sep 08, 2016 at 04:59:53PM +0100, Nick Warne wrote:
> > On Thu, 8 Sep 2016 08:29:37 +0200
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >   
> > > On Wed, Sep 07, 2016 at 05:38:52PM +0100, Nick Warne wrote:  
> > > > Hi Daniel,
> > > > 
> > > > kernel build 4.4.20 - I am still seeing this warning:
> > > > 
> > > > drivers/gpu/drm/i915/intel_display.c: In function
> > > > ‘intel_plane_obj_offset’:
> > > > drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to
> > > > pointer from integer of different size [-Wint-to-pointer-cast]
> > > > offset = (unsigned char *)vma->node.start;
> > > > 
> > > > but according to here:
> > > > 
> > > > https://patchwork.kernel.org/patch/7897461/
> > > > 
> > > > this has been fixed up.  Any reason why it hasn't in the latest
> > > > 4.4.x longterm tree?    
> > > 
> > > What is the commit id that fixed this in Linus's tree?  
> > 
> > Took me a while to find it if this is it - a bit of a re-write in
> > the whole file I think:
> > 
> > https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f  
> 
> Ick, messy.
> 
> Why not just use 4.7?  Why are you stuck at 4.4?

OK, running on 4.7.3 - no issues, all Hunky Dory.

Thanks Greg and kernel people - grand job you all do!

Best regards,

Nick
-- 
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-09-10 10:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-07 16:38 drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer Nick Warne
2016-09-08  6:29 ` Greg Kroah-Hartman
2016-09-08 15:59   ` Nick Warne
2016-09-09 11:55     ` Greg Kroah-Hartman
2016-09-09 12:55       ` Nick Warne
2016-09-10 10:48       ` Nick Warne

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox