From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753342AbcIIPne (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Sep 2016 11:43:34 -0400
Received: from mail.kernel.org ([198.145.29.136]:38026 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751212AbcIIPnb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Sep 2016 11:43:31 -0400
Date: Fri, 9 Sep 2016 12:43:22 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>
Subject: Re: [BUGFIX] Re: [PATCH v2 3/3] perf-probe: Support probing on
 offline cross-arch binary
Message-ID: <20160909154322.GE32585@kernel.org>
References: <147214224523.23638.10155676067678947950.stgit@devbox>
 <147214229717.23638.6440579792548044658.stgit@devbox>
 <20160831205411.GB13095@kernel.org>
 <20160901082525.e680f790cc64d41fb88efa63@kernel.org>
 <20160909143741.GB32585@kernel.org>
 <20160909145955.GC32585@kernel.org>
 <20160910002807.cab045734461c971ea2b3e3b@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160910002807.cab045734461c971ea2b3e3b@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Sat, Sep 10, 2016 at 12:28:07AM +0900, Masami Hiramatsu escreveu:
> On Fri, 9 Sep 2016 11:59:55 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > # diff /tmp/fail /tmp/ok
> > <SNIP>
> > -Writing event: p:perf_bpf_probe/func _text+5197232 f_mode=+68(%di):x32 offset=%si:s64 orig=dx:s32
> > -Failed to write event: Invalid argument
> > -bpf_probe: failed to apply perf probe eventsFailed to add events selected by BPF
> > +Writing event: p:perf_bpf_probe/func _text+5197232 f_mode=+68(%di):x32 offset=%si:s64 orig=%dx:s32
> > <SNIP>

> > Fixed by this patch:

> > +++ b/tools/perf/arch/x86/include/dwarf-regs-table.h
> > @@ -7,7 +7,7 @@ static const char * const x86_32_regstr_tbl[] = {
> >  };

> >  static const char * const x86_64_regstr_tbl[] = {
> > -	"%ax", "dx", "%cx", "%bx", "%si", "%di",
> > +	"%ax", "%dx", "%cx", "%bx", "%si", "%di",
> >  	"%bp", "%sp", "%r8", "%r9", "%r10", "%r11",
> >  	"%r12", "%r13", "%r14", "%r15",
> >  };
 
> Oops, it's my typo... thank you for reporting and fixing!

Right, but it was my fault as well, I should've payed attention to the
output of 'perf test' and replied to you so that you could figure this
out and resend.

Anyway, its good that this gets exercised by that test, its just a
matter of us making sure that no regressions appear on 'perf test'
before pushing things upstream.
 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks, added it to the patch.

- Arnaldo

- Arnaldo