From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbcIJDkB (ORCPT ); Fri, 9 Sep 2016 23:40:01 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:34322 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbcIJDj6 (ORCPT ); Fri, 9 Sep 2016 23:39:58 -0400 Date: Sat, 10 Sep 2016 11:39:53 +0800 From: Peter Chen To: Harish Jenny K N Cc: Felipe Balbi , linux-usb@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jim Baxter Subject: Re: [PATCH v1 1/2] usb: gadget: u_ether: fix another dereference after null check Message-ID: <20160910033953.GC6202@b29397-desktop> References: <1473413442-2377-1-git-send-email-harish_kandiga@mentor.com> <1473413442-2377-2-git-send-email-harish_kandiga@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473413442-2377-2-git-send-email-harish_kandiga@mentor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 11:30:41AM +0200, Harish Jenny K N wrote: > dev->port_usb is checked for null pointer previously, so dev->port_usb > might be null during no zlp check, fix it by adding null pointer check. > > Acked-by: Jim Baxter > Signed-off-by: Harish Jenny K N > --- > drivers/usb/gadget/function/u_ether.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c > index 3be4b93..9c8c9ed 100644 > --- a/drivers/usb/gadget/function/u_ether.c > +++ b/drivers/usb/gadget/function/u_ether.c > @@ -571,7 +571,8 @@ static netdev_tx_t eth_start_xmit(struct sk_buff *skb, > req->complete = tx_complete; > > /* NCM requires no zlp if transfer is dwNtbInMaxSize */ > - if (dev->port_usb->is_fixed && > + if (dev->port_usb && > + dev->port_usb->is_fixed && > length == dev->port_usb->fixed_in_len && > (length % in->maxpacket) == 0) > req->zero = 0; Acked-by: Peter Chen -- Best Regards, Peter Chen