From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbcIKIFn (ORCPT ); Sun, 11 Sep 2016 04:05:43 -0400 Received: from mga05.intel.com ([192.55.52.43]:42214 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbcIKIFg (ORCPT ); Sun, 11 Sep 2016 04:05:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,315,1470726000"; d="scan'208";a="877436204" Date: Sun, 11 Sep 2016 11:05:06 +0300 From: Mika Westerberg To: Phidias Chiang Cc: Anisse Astier , Linus Walleij , Heikki Krogerus , Yu C Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Message-ID: <20160911080506.GO15313@lahna.fi.intel.com> References: <20160818121328.GE30827@lahna.fi.intel.com> <20160818135813.GJ30827@lahna.fi.intel.com> <20160908101303.GA22716@ktx> <20160908102402.GC15313@lahna.fi.intel.com> <20160908162843.GB22716@ktx> <20160909061834.GG15313@lahna.fi.intel.com> <20160909082358.GA23895@ktx> <20160909085832.GK15313@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160909085832.GK15313@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2016 at 11:58:32AM +0300, Mika Westerberg wrote: > On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote: > > On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote: > > > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > > > > > > Hmm, how can that happen? The patch removes clearing of INTMASK and only > > > other place where it is cleared temporarily is on resume. Can you add > > > dev_info() calls like: > > > > > > /* Clear all interrupts */ > > > chv_writel(0xffff, pctrl->regs + CHV_INTSTAT); > > > dev_info(pctrl->dev, "INTMASK0: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > > > > > > ... > > > > > > gpiochip_set_chained_irqchip(chip, &chv_gpio_irqchip, irq, > > > chv_gpio_irq_handler); > > > dev_info(pctrl->dev, "INTMASK1: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > > > return 0; > > > > > > It should print the same values both time. > > > > > > Also which interrupt does not work and can you send me output of > > > /proc/interrupts? > > > > Output in dmesg: > > [ 2.054475] cherryview-pinctrl INT33FF:00: INTMASK0: 0x00000006 > > [ 2.055247] cherryview-pinctrl INT33FF:00: INTMASK1: 0x00000000 > > [ 2.055375] cherryview-pinctrl INT33FF:01: INTMASK0: 0x00004000 > > [ 2.056931] cherryview-pinctrl INT33FF:01: INTMASK1: 0x00000000 > > [ 2.057036] cherryview-pinctrl INT33FF:02: INTMASK0: 0x00000000 > > [ 2.057367] cherryview-pinctrl INT33FF:02: INTMASK1: 0x00000000 > > [ 2.057489] cherryview-pinctrl INT33FF:03: INTMASK0: 0x00000000 > > [ 2.058337] cherryview-pinctrl INT33FF:03: INTMASK1: 0x00000000 > > > > So it's somehow got cleared in the process after. > > Only other place where we touch INTMASK register is > chv_gpio_irq_mask_unmask(). Can you add some debug there to find out the > caller? Something like this: diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c index 0fe8fad..95fa3b1 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1357,6 +1357,11 @@ static void chv_gpio_irq_mask_unmask(struct irq_data *d, bool mask) value |= BIT(intr_line); chv_writel(value, pctrl->regs + CHV_INTMASK); + if (printk_ratelimit()) { + dev_info(pctrl->dev, "%smask pin %u intmask 0x%08x\n", + mask ? "" : "un", pin, readl(pctrl->regs + CHV_INTMASK)); + } + raw_spin_unlock_irqrestore(&chv_lock, flags); }