From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932759AbcILEwP (ORCPT <rfc822;w@1wt.eu>);
        Mon, 12 Sep 2016 00:52:15 -0400
Received: from mail.kernel.org ([198.145.29.136]:34860 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932725AbcILEwO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 12 Sep 2016 00:52:14 -0400
Date: Mon, 12 Sep 2016 07:52:07 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>,
        Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree
 instead of vfree
Message-ID: <20160912045207.GC8812@leon.nu>
References: <20160909071537.18821-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="/Uq4LBwYP4y1W6pO"
Content-Disposition: inline
In-Reply-To: <20160909071537.18821-1-colin.king@canonical.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--/Uq4LBwYP4y1W6pO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 09, 2016 at 08:15:37AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The userspace memory region 'mr' is allocated with kzalloc in
> __rvt_alloc_mr  however it is incorrectly being freed with vfree in
> __rvt_free_mr. Fix this by using kfree to free it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

> ---
>  drivers/infiniband/sw/rdmavt/mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rdmavt/mr.c b/drivers/infiniband/sw/rdmavt/mr.c
> index 80c4b6b..46b6497 100644
> --- a/drivers/infiniband/sw/rdmavt/mr.c
> +++ b/drivers/infiniband/sw/rdmavt/mr.c
> @@ -294,7 +294,7 @@ static void __rvt_free_mr(struct rvt_mr *mr)
>  {
>  	rvt_deinit_mregion(&mr->mr);
>  	rvt_free_lkey(&mr->mr);
> -	vfree(mr);
> +	kfree(mr);
>  }
>
>  /**
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--/Uq4LBwYP4y1W6pO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJX1jR3AAoJEORje4g2clinC4YQAK3RvZYvAuN8MgcCRnEWKMal
uGdUca+4e/M4qRRnRzGD6VSsu6gqUYTEJP3sDQEpvti3NfHMyxd/6UjSTtdeJ5kH
lEIsxKiiiio3QM/VXOjlUaspIRYcapfnnlcVqlXahyeIUVC6+grG22HPIAgwGQZ+
jKSXVW8PIf/F3zzbqZX8FsGehxOkmBySwhVsKUth9fRVJSFbV/Xqn/3xpJu3OzAR
EPnaBAk71QSbKOpMA2DQ2dXF0mYyvb+OOFl34cD1sKyv2w2xdPNEnDfNkLO3a18e
Dr+hPtFk0XdQgF6LwTay8A6cIy3mYSxXEU4mlY9gi5hUBPyapTC6o0dnXIc6uduG
bz1rEA1ADSZTodlMhLrcwWx75Vku1k7eGRdiY8suHbiiNbXWNl1EK4mboKvrlgy0
KZtgCnVHorEvzVVr6oDI9nXQx0TSWqjqBYVgPPBFZ6H5ao16KRozmcYF20VMwfbo
YTFlA6DaMHBTDfYw42QWAX2mq0CB9o+v0hPf1JkermAP2f/O3VitnZUyWrxJMi6J
PW/lvaZjh3bhV8TQQsEPP/T5FHeyjYMB/x31RpVeB4MoNEQXhhexZ9jU8EA6wsst
sVM5M8XBw5+GtrdJKI0ItmEQ5PplS1oLAJ1ip+Jy/2/I9IKeqPnPv9pUbVWDTz2M
ArEDXZtJbfQu0CPXtAOb
=ih+e
-----END PGP SIGNATURE-----

--/Uq4LBwYP4y1W6pO--