From: Greg KH <gregkh@linuxfoundation.org>
To: Sabitha George <sabitha.george@gmail.com>
Cc: wsa@the-dreams.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] staging: ks7010: Fix warnings on printk() usage
Date: Mon, 12 Sep 2016 10:58:50 +0200 [thread overview]
Message-ID: <20160912085850.GA21753@kroah.com> (raw)
In-Reply-To: <1472923309-14945-1-git-send-email-sabitha.george@gmail.com>
On Sat, Sep 03, 2016 at 10:51:49PM +0530, Sabitha George wrote:
> This patch fixes the following warnings on ks7010_sdio.c
> 1. printk() should include KERN_ facility level
> 2. Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: Sabitha George <sabitha.george@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 67b01a6..d45bacd 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -499,8 +499,8 @@ static void ks7010_rw_function(struct work_struct *work)
> DPRINTK(4, "wait after WAKEUP \n");
> /* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
> - printk("wake: %lu %lu\n", priv->last_wakeup + (30 * HZ) / 1000,
> - jiffies);
> + pr_info("wake: %lu %lu\n", priv->last_wakeup + (30 * HZ) / 1000,
> + jiffies);
> msleep(30);
> }
>
> @@ -1010,11 +1010,11 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> /* private memory allocate */
> netdev = alloc_etherdev(sizeof(*priv));
> if (netdev == NULL) {
> - printk(KERN_ERR "ks7010 : Unable to alloc new net device\n");
> + pr_err("ks7010 : Unable to alloc new net device\n");
> goto error_release_irq;
> }
> if (dev_alloc_name(netdev, "wlan%d") < 0) {
> - printk(KERN_ERR "ks7010 : Couldn't get name!\n");
> + pr_err("ks7010 : Couldn't get name!\n");
> goto error_free_netdev;
> }
>
> @@ -1054,8 +1054,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> /* Upload firmware */
> ret = ks7010_upload_firmware(priv, card); /* firmware load */
> if (ret) {
> - printk(KERN_ERR
> - "ks7010: firmware load failed !! retern code = %d\n",
> + pr_err("ks7010: firmware load failed !! retern code = %d\n",
> ret);
This is a driver, so please use dev_err() where ever possible (I think
it can be used in two of the above places, maybe all three.)
thanks,
greg k-h
prev parent reply other threads:[~2016-09-12 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 17:21 [PATCH 4/5] staging: ks7010: Fix warnings on printk() usage Sabitha George
2016-09-12 8:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912085850.GA21753@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sabitha.george@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox