From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757752AbcILJRf (ORCPT ); Mon, 12 Sep 2016 05:17:35 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32797 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755823AbcILJRd (ORCPT ); Mon, 12 Sep 2016 05:17:33 -0400 Date: Mon, 12 Sep 2016 11:17:37 +0200 From: Greg KH To: Baoyou Xie Cc: wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [PATCH] staging: ks7010: mark symbols static where possible Message-ID: <20160912091737.GA31664@kroah.com> References: <1472971119-4560-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472971119-4560-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 04, 2016 at 02:38:39PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] > drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This patch is already in my tree :(