From: Greg KH <gregkh@linuxfoundation.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: wsa@the-dreams.de, devel@driverdev.osuosl.org,
xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH] staging: ks7010: mark symbols static where possible
Date: Mon, 12 Sep 2016 11:19:15 +0200 [thread overview]
Message-ID: <20160912091915.GA5785@kroah.com> (raw)
In-Reply-To: <1473334644-26133-1-git-send-email-baoyou.xie@linaro.org>
On Thu, Sep 08, 2016 at 07:37:24PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:121:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:174:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Does not apply to my tree :(
next prev parent reply other threads:[~2016-09-12 9:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 11:37 [PATCH] staging: ks7010: mark symbols static where possible Baoyou Xie
2016-09-12 9:19 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-09-04 6:38 Baoyou Xie
2016-09-05 11:49 ` Arnd Bergmann
2016-09-12 9:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912091915.GA5785@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox