From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757624AbcILJpo (ORCPT ); Mon, 12 Sep 2016 05:45:44 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33412 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcILJpk (ORCPT ); Mon, 12 Sep 2016 05:45:40 -0400 Date: Mon, 12 Sep 2016 11:45:45 +0200 From: Greg KH To: Baoyou Xie Cc: Sudip Mukherjee , arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, Linux Kernel Mailing List , Arnd Bergmann Subject: Re: [PATCH] staging/android: mark sync_timeline_create() static Message-ID: <20160912094545.GA20335@kroah.com> References: <1472884453-19941-1-git-send-email-baoyou.xie@linaro.org> <20160904154101.GD29779@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2016 at 08:40:25AM +0800, Baoyou Xie wrote: > > > On 4 September 2016 at 23:41, Sudip Mukherjee > wrote: > > On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > > We get 1 warning when building kernel with W=1: > > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype > for 'sync_timeline_create' [-Wmissing-prototypes] > > > > In fact, this function is only used in the file in which it is > > declared and don't need a declaration, but can be made static. > > so this patch marks this function with 'static'. > > > > Signed-off-by: Baoyou Xie > > --- > >  drivers/staging/android/sw_sync.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > which tree are you using? > > > I using master tree with 4.8-rc1 That's a quick way to ensure that your patches will not apply, as that tree does not contain any of the patches submitted since then. Please always work against linux-next or my staging-next tree for staging patches. thanks, greg k-h