From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771AbcILJ7w (ORCPT ); Mon, 12 Sep 2016 05:59:52 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33213 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756716AbcILJ6s (ORCPT ); Mon, 12 Sep 2016 05:58:48 -0400 Date: Mon, 12 Sep 2016 11:00:37 +0100 From: Lee Jones To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] mfd: sm501: constify gpio_chip structures Message-ID: <20160912100037.GE1873@dell> References: <1473596082-32690-1-git-send-email-Julia.Lawall@lip6.fr> <1473596082-32690-3-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473596082-32690-3-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Julia Lawall wrote: > These structures are only used to copy into other structures, so declare > them as const. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct gpio_chip i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct gpio_chip e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct gpio_chip i = { ... }; > // > > Signed-off-by: Julia Lawall > > --- > drivers/mfd/sm501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c > index 65cd0d2..4053435 100644 > --- a/drivers/mfd/sm501.c > +++ b/drivers/mfd/sm501.c > @@ -1001,7 +1001,7 @@ static int sm501_gpio_output(struct gpio_chip *chip, > return 0; > } > > -static struct gpio_chip gpio_chip_template = { > +static const struct gpio_chip gpio_chip_template = { > .ngpio = 32, > .direction_input = sm501_gpio_input, > .direction_output = sm501_gpio_output, > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog