* [PATCH 0/6] constify gpio_chip structures
@ 2016-09-11 12:14 Julia Lawall
2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw)
To: linux-kernel
Cc: kernel-janitors, linux-gpio, linux-arm-kernel,
bcm-kernel-feedback-list, linux-mediatek, alsa-devel
Constify gpio_chip structures
---
drivers/gpio/gpio-arizona.c | 2 +-
drivers/gpio/gpio-bcm-kona.c | 2 +-
drivers/gpio/gpio-da9052.c | 2 +-
drivers/gpio/gpio-da9055.c | 2 +-
drivers/gpio/gpio-it87.c | 2 +-
drivers/gpio/gpio-lp873x.c | 2 +-
drivers/gpio/gpio-lpc18xx.c | 2 +-
drivers/gpio/gpio-pisosr.c | 2 +-
drivers/gpio/gpio-sch.c | 2 +-
drivers/gpio/gpio-stmpe.c | 2 +-
drivers/gpio/gpio-tc3589x.c | 2 +-
drivers/gpio/gpio-tpic2810.c | 2 +-
drivers/gpio/gpio-tps65086.c | 2 +-
drivers/gpio/gpio-tps65218.c | 2 +-
drivers/gpio/gpio-tps65912.c | 2 +-
drivers/gpio/gpio-ts4900.c | 2 +-
drivers/gpio/gpio-twl4030.c | 2 +-
drivers/gpio/gpio-wm831x.c | 2 +-
drivers/gpio/gpio-wm8350.c | 2 +-
drivers/gpio/gpio-wm8994.c | 2 +-
drivers/mfd/sm501.c | 2 +-
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +-
drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +-
sound/soc/codecs/rt5677.c | 2 +-
sound/soc/codecs/wm5100.c | 2 +-
sound/soc/codecs/wm8903.c | 2 +-
sound/soc/codecs/wm8962.c | 2 +-
sound/soc/codecs/wm8996.c | 2 +-
sound/soc/soc-ac97.c | 2 +-
29 files changed, 29 insertions(+), 29 deletions(-)
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/6] gpio: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 2016-09-11 13:13 ` Joachim Eastwood 2016-09-13 8:35 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 2/6] mfd: sm501: " Julia Lawall ` (4 subsequent siblings) 5 siblings, 2 replies; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Alexandre Courbot Cc: kernel-janitors, Support Opensource, Linus Walleij, patches, linux-gpio, linux-kernel, Joachim Eastwood, linux-arm-kernel, Ray Jui, Florian Fainelli, Scott Branden, bcm-kernel-feedback-list These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/gpio/gpio-arizona.c | 2 +- drivers/gpio/gpio-bcm-kona.c | 2 +- drivers/gpio/gpio-da9052.c | 2 +- drivers/gpio/gpio-da9055.c | 2 +- drivers/gpio/gpio-it87.c | 2 +- drivers/gpio/gpio-lp873x.c | 2 +- drivers/gpio/gpio-lpc18xx.c | 2 +- drivers/gpio/gpio-pisosr.c | 2 +- drivers/gpio/gpio-sch.c | 2 +- drivers/gpio/gpio-stmpe.c | 2 +- drivers/gpio/gpio-tc3589x.c | 2 +- drivers/gpio/gpio-tpic2810.c | 2 +- drivers/gpio/gpio-tps65086.c | 2 +- drivers/gpio/gpio-tps65218.c | 2 +- drivers/gpio/gpio-tps65912.c | 2 +- drivers/gpio/gpio-ts4900.c | 2 +- drivers/gpio/gpio-twl4030.c | 2 +- drivers/gpio/gpio-wm831x.c | 2 +- drivers/gpio/gpio-wm8350.c | 2 +- drivers/gpio/gpio-wm8994.c | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c index 9913704..4824628 100644 --- a/drivers/gpio/gpio-arizona.c +++ b/drivers/gpio/gpio-arizona.c @@ -79,7 +79,7 @@ static void arizona_gpio_set(struct gpio_chip *chip, unsigned offset, int value) ARIZONA_GPN_LVL, value); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "arizona", .owner = THIS_MODULE, .direction_input = arizona_gpio_direction_in, diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index 21f97bc..533707f 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -247,7 +247,7 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) #define wm831x_gpio_dbg_show NULL #endif -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "wm831x", .owner = THIS_MODULE, .direction_input = wm831x_gpio_direction_in, diff --git a/drivers/gpio/gpio-wm8350.c b/drivers/gpio/gpio-wm8350.c index e976570..e46752e 100644 --- a/drivers/gpio/gpio-wm8350.c +++ b/drivers/gpio/gpio-wm8350.c @@ -93,7 +93,7 @@ static int wm8350_gpio_to_irq(struct gpio_chip *chip, unsigned offset) return wm8350->irq_base + WM8350_IRQ_GPIO(offset); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "wm8350", .owner = THIS_MODULE, .direction_input = wm8350_gpio_direction_in, diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index 2457aac..68410fd 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -249,7 +249,7 @@ static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) #define wm8994_gpio_dbg_show NULL #endif -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "wm8994", .owner = THIS_MODULE, .request = wm8994_gpio_request, diff --git a/drivers/gpio/gpio-it87.c b/drivers/gpio/gpio-it87.c index 63a962d..45d29e4 100644 --- a/drivers/gpio/gpio-it87.c +++ b/drivers/gpio/gpio-it87.c @@ -273,7 +273,7 @@ exit: return rc; } -static struct gpio_chip it87_template_chip = { +static const struct gpio_chip it87_template_chip = { .label = KBUILD_MODNAME, .owner = THIS_MODULE, .request = it87_gpio_request, diff --git a/drivers/gpio/gpio-lp873x.c b/drivers/gpio/gpio-lp873x.c index f10d49d..134f6b3 100644 --- a/drivers/gpio/gpio-lp873x.c +++ b/drivers/gpio/gpio-lp873x.c @@ -124,7 +124,7 @@ static int lp873x_gpio_set_single_ended(struct gpio_chip *gc, } } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "lp873x-gpio", .owner = THIS_MODULE, .request = lp873x_gpio_request, diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index cb14b8d..f5545049 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -90,7 +90,7 @@ static int pisosr_gpio_get(struct gpio_chip *chip, unsigned offset) return (gpio->buffer[offset / 8] >> (offset % 8)) & 0x1; } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "pisosr-gpio", .owner = THIS_MODULE, .get_direction = pisosr_gpio_get_direction, diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c index eb43ae4..5450044 100644 --- a/drivers/gpio/gpio-sch.c +++ b/drivers/gpio/gpio-sch.c @@ -138,7 +138,7 @@ static int sch_gpio_direction_out(struct gpio_chip *gc, unsigned gpio_num, return 0; } -static struct gpio_chip sch_gpio_chip = { +static const struct gpio_chip sch_gpio_chip = { .label = "sch_gpio", .owner = THIS_MODULE, .direction_input = sch_gpio_direction_in, diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c index 5c0d818..b51c5be 100644 --- a/drivers/gpio/gpio-stmpe.c +++ b/drivers/gpio/gpio-stmpe.c @@ -121,7 +121,7 @@ static int stmpe_gpio_request(struct gpio_chip *chip, unsigned offset) return stmpe_set_altfunc(stmpe, 1 << offset, STMPE_BLOCK_GPIO); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "stmpe", .owner = THIS_MODULE, .get_direction = stmpe_gpio_get_direction, diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c index 8b36593..5baa457 100644 --- a/drivers/gpio/gpio-tc3589x.c +++ b/drivers/gpio/gpio-tc3589x.c @@ -124,7 +124,7 @@ static int tc3589x_gpio_single_ended(struct gpio_chip *chip, return -ENOTSUPP; } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "tc3589x", .owner = THIS_MODULE, .direction_input = tc3589x_gpio_direction_input, diff --git a/drivers/gpio/gpio-tpic2810.c b/drivers/gpio/gpio-tpic2810.c index cace79c..c8b34d7 100644 --- a/drivers/gpio/gpio-tpic2810.c +++ b/drivers/gpio/gpio-tpic2810.c @@ -87,7 +87,7 @@ static void tpic2810_set_multiple(struct gpio_chip *chip, unsigned long *mask, tpic2810_set_mask_bits(chip, *mask, *bits); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "tpic2810", .owner = THIS_MODULE, .get_direction = tpic2810_get_direction, diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c index 8e25f01..b23c4d2 100644 --- a/drivers/gpio/gpio-tps65086.c +++ b/drivers/gpio/gpio-tps65086.c @@ -72,7 +72,7 @@ static void tps65086_gpio_set(struct gpio_chip *chip, unsigned offset, BIT(4 + offset), value ? BIT(4 + offset) : 0); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "tps65086-gpio", .owner = THIS_MODULE, .get_direction = tps65086_gpio_get_direction, diff --git a/drivers/gpio/gpio-tps65218.c b/drivers/gpio/gpio-tps65218.c index 1c09a19..03e0dfb 100644 --- a/drivers/gpio/gpio-tps65218.c +++ b/drivers/gpio/gpio-tps65218.c @@ -172,7 +172,7 @@ static int tps65218_gpio_set_single_ended(struct gpio_chip *gc, return -ENOTSUPP; } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "gpio-tps65218", .owner = THIS_MODULE, .request = tps65218_gpio_request, diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c index acfd30a..abc0798 100644 --- a/drivers/gpio/gpio-tps65912.c +++ b/drivers/gpio/gpio-tps65912.c @@ -90,7 +90,7 @@ static void tps65912_gpio_set(struct gpio_chip *gc, unsigned offset, GPIO_SET_MASK, value ? GPIO_SET_MASK : 0); } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "tps65912-gpio", .owner = THIS_MODULE, .get_direction = tps65912_gpio_get_direction, diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c index 9dd9aca..5bd2172 100644 --- a/drivers/gpio/gpio-ts4900.c +++ b/drivers/gpio/gpio-ts4900.c @@ -101,7 +101,7 @@ static const struct regmap_config ts4900_regmap_config = { .val_bits = 8, }; -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "ts4900-gpio", .owner = THIS_MODULE, .get_direction = ts4900_gpio_get_direction, diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c index 4b807b0..dfcfbba 100644 --- a/drivers/gpio/gpio-twl4030.c +++ b/drivers/gpio/gpio-twl4030.c @@ -381,7 +381,7 @@ static int twl_to_irq(struct gpio_chip *chip, unsigned offset) : -EINVAL; } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "twl4030", .owner = THIS_MODULE, .request = twl_request, diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c index 98832c9..f12e02e 100644 --- a/drivers/gpio/gpio-lpc18xx.c +++ b/drivers/gpio/gpio-lpc18xx.c @@ -78,7 +78,7 @@ static int lpc18xx_gpio_direction_output(struct gpio_chip *chip, return lpc18xx_gpio_direction(chip, offset, true); } -static struct gpio_chip lpc18xx_chip = { +static const struct gpio_chip lpc18xx_chip = { .label = "lpc18xx/43xx-gpio", .request = gpiochip_generic_request, .free = gpiochip_generic_free, diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c index e29553b..dd8977c 100644 --- a/drivers/gpio/gpio-da9052.c +++ b/drivers/gpio/gpio-da9052.c @@ -184,7 +184,7 @@ static int da9052_gpio_to_irq(struct gpio_chip *gc, u32 offset) return irq; } -static struct gpio_chip reference_gp = { +static const struct gpio_chip reference_gp = { .label = "da9052-gpio", .owner = THIS_MODULE, .get = da9052_gpio_get, diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c index 2c2c18d..82053b5 100644 --- a/drivers/gpio/gpio-da9055.c +++ b/drivers/gpio/gpio-da9055.c @@ -121,7 +121,7 @@ static int da9055_gpio_to_irq(struct gpio_chip *gc, u32 offset) DA9055_IRQ_GPI0 + offset); } -static struct gpio_chip reference_gp = { +static const struct gpio_chip reference_gp = { .label = "da9055-gpio", .owner = THIS_MODULE, .get = da9055_gpio_get, diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 953e4b8..3d1cf01 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -308,7 +308,7 @@ static int bcm_kona_gpio_set_debounce(struct gpio_chip *chip, unsigned gpio, return 0; } -static struct gpio_chip template_chip = { +static const struct gpio_chip template_chip = { .label = "bcm-kona-gpio", .owner = THIS_MODULE, .request = bcm_kona_gpio_request, ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: constify gpio_chip structures 2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall @ 2016-09-11 13:13 ` Joachim Eastwood 2016-09-13 8:35 ` Linus Walleij 1 sibling, 0 replies; 13+ messages in thread From: Joachim Eastwood @ 2016-09-11 13:13 UTC (permalink / raw) To: Julia Lawall Cc: Alexandre Courbot, kernel-janitors, Support Opensource, Linus Walleij, patches, linux-gpio, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ray Jui, Florian Fainelli, Scott Branden, bcm-kernel-feedback-list Hi Julia, On 11 September 2016 at 14:14, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > These structures are only used to copy into other structures, so declare > them as const. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct gpio_chip i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct gpio_chip e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct gpio_chip i = { ... }; > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/gpio/gpio-arizona.c | 2 +- > drivers/gpio/gpio-bcm-kona.c | 2 +- > drivers/gpio/gpio-da9052.c | 2 +- > drivers/gpio/gpio-da9055.c | 2 +- > drivers/gpio/gpio-it87.c | 2 +- > drivers/gpio/gpio-lp873x.c | 2 +- > drivers/gpio/gpio-lpc18xx.c | 2 +- > drivers/gpio/gpio-pisosr.c | 2 +- > drivers/gpio/gpio-sch.c | 2 +- > drivers/gpio/gpio-stmpe.c | 2 +- > drivers/gpio/gpio-tc3589x.c | 2 +- > drivers/gpio/gpio-tpic2810.c | 2 +- > drivers/gpio/gpio-tps65086.c | 2 +- > drivers/gpio/gpio-tps65218.c | 2 +- > drivers/gpio/gpio-tps65912.c | 2 +- > drivers/gpio/gpio-ts4900.c | 2 +- > drivers/gpio/gpio-twl4030.c | 2 +- > drivers/gpio/gpio-wm831x.c | 2 +- > drivers/gpio/gpio-wm8350.c | 2 +- > drivers/gpio/gpio-wm8994.c | 2 +- > 20 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c > index 98832c9..f12e02e 100644 > --- a/drivers/gpio/gpio-lpc18xx.c > +++ b/drivers/gpio/gpio-lpc18xx.c > @@ -78,7 +78,7 @@ static int lpc18xx_gpio_direction_output(struct gpio_chip *chip, > return lpc18xx_gpio_direction(chip, offset, true); > } > > -static struct gpio_chip lpc18xx_chip = { > +static const struct gpio_chip lpc18xx_chip = { > .label = "lpc18xx/43xx-gpio", > .request = gpiochip_generic_request, > .free = gpiochip_generic_free, For lpc18xx: Acked-by: Joachim Eastwood <manabian@gmail.com> regards, Joachim Eastwood ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/6] gpio: constify gpio_chip structures 2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall 2016-09-11 13:13 ` Joachim Eastwood @ 2016-09-13 8:35 ` Linus Walleij 1 sibling, 0 replies; 13+ messages in thread From: Linus Walleij @ 2016-09-13 8:35 UTC (permalink / raw) To: Julia Lawall Cc: Alexandre Courbot, kernel-janitors, Support Opensource, open list:WOLFSON MICROELECTRONICS DRIVERS, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Joachim Eastwood, linux-arm-kernel@lists.infradead.org, Ray Jui, Florian Fainelli, Scott Branden, bcm-kernel-feedback-list On Sun, Sep 11, 2016 at 2:14 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > These structures are only used to copy into other structures, so declare > them as const. (...) > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Patch applied, awesome work as always, thanks! Yours, Linus Walleij ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/6] mfd: sm501: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall 2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 2016-09-12 10:00 ` Lee Jones 2016-09-11 12:14 ` [PATCH 3/6] pinctrl: mediatek: " Julia Lawall ` (3 subsequent siblings) 5 siblings, 1 reply; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Lee Jones; +Cc: kernel-janitors, linux-kernel These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/mfd/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 65cd0d2..4053435 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1001,7 +1001,7 @@ static int sm501_gpio_output(struct gpio_chip *chip, return 0; } -static struct gpio_chip gpio_chip_template = { +static const struct gpio_chip gpio_chip_template = { .ngpio = 32, .direction_input = sm501_gpio_input, .direction_output = sm501_gpio_output, ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/6] mfd: sm501: constify gpio_chip structures 2016-09-11 12:14 ` [PATCH 2/6] mfd: sm501: " Julia Lawall @ 2016-09-12 10:00 ` Lee Jones 0 siblings, 0 replies; 13+ messages in thread From: Lee Jones @ 2016-09-12 10:00 UTC (permalink / raw) To: Julia Lawall; +Cc: kernel-janitors, linux-kernel On Sun, 11 Sep 2016, Julia Lawall wrote: > These structures are only used to copy into other structures, so declare > them as const. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct gpio_chip i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct gpio_chip e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct gpio_chip i = { ... }; > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/mfd/sm501.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c > index 65cd0d2..4053435 100644 > --- a/drivers/mfd/sm501.c > +++ b/drivers/mfd/sm501.c > @@ -1001,7 +1001,7 @@ static int sm501_gpio_output(struct gpio_chip *chip, > return 0; > } > > -static struct gpio_chip gpio_chip_template = { > +static const struct gpio_chip gpio_chip_template = { > .ngpio = 32, > .direction_input = sm501_gpio_input, > .direction_output = sm501_gpio_output, > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/6] pinctrl: mediatek: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall 2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall 2016-09-11 12:14 ` [PATCH 2/6] mfd: sm501: " Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 2016-09-13 8:40 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 4/6] pinctrl: stm32: " Julia Lawall ` (2 subsequent siblings) 5 siblings, 1 reply; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Linus Walleij Cc: kernel-janitors, Matthias Brugger, linux-gpio, linux-arm-kernel, linux-mediatek, linux-kernel These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index ba2b03d..f9aef2a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -1054,7 +1054,7 @@ static int mtk_gpio_set_debounce(struct gpio_chip *chip, unsigned offset, return 0; } -static struct gpio_chip mtk_gpio_chip = { +static const struct gpio_chip mtk_gpio_chip = { .owner = THIS_MODULE, .request = gpiochip_generic_request, .free = gpiochip_generic_free, ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] pinctrl: mediatek: constify gpio_chip structures 2016-09-11 12:14 ` [PATCH 3/6] pinctrl: mediatek: " Julia Lawall @ 2016-09-13 8:40 ` Linus Walleij 0 siblings, 0 replies; 13+ messages in thread From: Linus Walleij @ 2016-09-13 8:40 UTC (permalink / raw) To: Julia Lawall Cc: kernel-janitors, Matthias Brugger, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, moderated list:ARM/Mediatek SoC support, linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 2:14 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > These structures are only used to copy into other structures, so declare > them as const. (...) > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/6] pinctrl: stm32: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall ` (2 preceding siblings ...) 2016-09-11 12:14 ` [PATCH 3/6] pinctrl: mediatek: " Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 2016-09-13 8:38 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 5/6] ASoC: ac97: " Julia Lawall 2016-09-11 12:14 ` [PATCH 6/6] ASoC: constify gpio_chip structures Julia Lawall 5 siblings, 1 reply; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Alexandre Torgue Cc: kernel-janitors, Linus Walleij, Maxime Coquelin, linux-gpio, linux-arm-kernel, linux-kernel These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 4ae596b..6d92351 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c @@ -174,7 +174,7 @@ static int stm32_gpio_direction_output(struct gpio_chip *chip, return 0; } -static struct gpio_chip stm32_gpio_template = { +static const struct gpio_chip stm32_gpio_template = { .request = stm32_gpio_request, .free = stm32_gpio_free, .get = stm32_gpio_get, ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 4/6] pinctrl: stm32: constify gpio_chip structures 2016-09-11 12:14 ` [PATCH 4/6] pinctrl: stm32: " Julia Lawall @ 2016-09-13 8:38 ` Linus Walleij 0 siblings, 0 replies; 13+ messages in thread From: Linus Walleij @ 2016-09-13 8:38 UTC (permalink / raw) To: Julia Lawall Cc: Alexandre Torgue, kernel-janitors, Maxime Coquelin, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 2:14 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > These structures are only used to copy into other structures, so declare > them as const. (...) > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Patch applied, after some fuzzing. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 5/6] ASoC: ac97: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall ` (3 preceding siblings ...) 2016-09-11 12:14 ` [PATCH 4/6] pinctrl: stm32: " Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 2016-09-12 19:05 ` Applied "ASoC: ac97: constify gpio_chip structures" to the asoc tree Mark Brown 2016-09-11 12:14 ` [PATCH 6/6] ASoC: constify gpio_chip structures Julia Lawall 5 siblings, 1 reply; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Liam Girdwood Cc: kernel-janitors, Mark Brown, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/soc/soc-ac97.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index bc4a55b..6c8b0b0 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -116,7 +116,7 @@ static int snd_soc_ac97_gpio_direction_out(struct gpio_chip *chip, return snd_soc_update_bits(codec, AC97_GPIO_CFG, 1 << offset, 0); } -static struct gpio_chip snd_soc_ac97_gpio_chip = { +static const struct gpio_chip snd_soc_ac97_gpio_chip = { .label = "snd_soc_ac97", .owner = THIS_MODULE, .request = snd_soc_ac97_gpio_request, ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Applied "ASoC: ac97: constify gpio_chip structures" to the asoc tree 2016-09-11 12:14 ` [PATCH 5/6] ASoC: ac97: " Julia Lawall @ 2016-09-12 19:05 ` Mark Brown 0 siblings, 0 replies; 13+ messages in thread From: Mark Brown @ 2016-09-12 19:05 UTC (permalink / raw) To: Julia Lawall Cc: Mark Brown, Liam Girdwood, alsa-devel, kernel-janitors, linux-kernel, Takashi Iwai, Mark Brown The patch ASoC: ac97: constify gpio_chip structures has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 52abe54138d9b14b4a0a17742a53d2411bc5b167 Mon Sep 17 00:00:00 2001 From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Sun, 11 Sep 2016 14:14:41 +0200 Subject: [PATCH] ASoC: ac97: constify gpio_chip structures These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/soc-ac97.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index bc4a55bb3fd9..6c8b0b0c56ec 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -116,7 +116,7 @@ static int snd_soc_ac97_gpio_direction_out(struct gpio_chip *chip, return snd_soc_update_bits(codec, AC97_GPIO_CFG, 1 << offset, 0); } -static struct gpio_chip snd_soc_ac97_gpio_chip = { +static const struct gpio_chip snd_soc_ac97_gpio_chip = { .label = "snd_soc_ac97", .owner = THIS_MODULE, .request = snd_soc_ac97_gpio_request, -- 2.8.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 6/6] ASoC: constify gpio_chip structures 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall ` (4 preceding siblings ...) 2016-09-11 12:14 ` [PATCH 5/6] ASoC: ac97: " Julia Lawall @ 2016-09-11 12:14 ` Julia Lawall 5 siblings, 0 replies; 13+ messages in thread From: Julia Lawall @ 2016-09-11 12:14 UTC (permalink / raw) To: Liam Girdwood Cc: kernel-janitors, linux-kernel, alsa-devel, patches, Takashi Iwai, Jaroslav Kysela, Mark Brown, Bard Liao, Oder Chiou These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct gpio_chip e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct gpio_chip i = { ... }; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/soc/codecs/rt5677.c | 2 +- sound/soc/codecs/wm5100.c | 2 +- sound/soc/codecs/wm8903.c | 2 +- sound/soc/codecs/wm8962.c | 2 +- sound/soc/codecs/wm8996.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wm5100.c b/sound/soc/codecs/wm5100.c index 278467d..5605750 100644 --- a/sound/soc/codecs/wm5100.c +++ b/sound/soc/codecs/wm5100.c @@ -2285,7 +2285,7 @@ static int wm5100_gpio_direction_in(struct gpio_chip *chip, unsigned offset) (1 << WM5100_GP1_DIR_SHIFT)); } -static struct gpio_chip wm5100_template_chip = { +static const struct gpio_chip wm5100_template_chip = { .label = "wm5100", .owner = THIS_MODULE, .direction_output = wm5100_gpio_direction_out, diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 837c8b9..6e887c2 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1830,7 +1830,7 @@ static void wm8903_gpio_set(struct gpio_chip *chip, unsigned offset, int value) !!value << WM8903_GP1_LVL_SHIFT); } -static struct gpio_chip wm8903_template_chip = { +static const struct gpio_chip wm8903_template_chip = { .label = "wm8903", .owner = THIS_MODULE, .request = wm8903_gpio_request, diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 9f67922..fd2731d 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3357,7 +3357,7 @@ static int wm8962_gpio_direction_out(struct gpio_chip *chip, return 0; } -static struct gpio_chip wm8962_template_chip = { +static const struct gpio_chip wm8962_template_chip = { .label = "wm8962", .owner = THIS_MODULE, .request = wm8962_gpio_request, diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 5eba8ff..8affa49 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c @@ -2184,7 +2184,7 @@ static int wm8996_gpio_direction_in(struct gpio_chip *chip, unsigned offset) (1 << WM8996_GP1_DIR_SHIFT)); } -static struct gpio_chip wm8996_template_chip = { +static const struct gpio_chip wm8996_template_chip = { .label = "wm8996", .owner = THIS_MODULE, .direction_output = wm8996_gpio_direction_out, diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 68268f2..7df422c 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -4657,7 +4657,7 @@ static int rt5677_to_irq(struct gpio_chip *chip, unsigned offset) return regmap_irq_get_virq(data, irq); } -static struct gpio_chip rt5677_template_chip = { +static const struct gpio_chip rt5677_template_chip = { .label = "rt5677", .owner = THIS_MODULE, .direction_output = rt5677_gpio_direction_out, ^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-09-13 8:40 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-11 12:14 [PATCH 0/6] constify gpio_chip structures Julia Lawall 2016-09-11 12:14 ` [PATCH 1/6] gpio: " Julia Lawall 2016-09-11 13:13 ` Joachim Eastwood 2016-09-13 8:35 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 2/6] mfd: sm501: " Julia Lawall 2016-09-12 10:00 ` Lee Jones 2016-09-11 12:14 ` [PATCH 3/6] pinctrl: mediatek: " Julia Lawall 2016-09-13 8:40 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 4/6] pinctrl: stm32: " Julia Lawall 2016-09-13 8:38 ` Linus Walleij 2016-09-11 12:14 ` [PATCH 5/6] ASoC: ac97: " Julia Lawall 2016-09-12 19:05 ` Applied "ASoC: ac97: constify gpio_chip structures" to the asoc tree Mark Brown 2016-09-11 12:14 ` [PATCH 6/6] ASoC: constify gpio_chip structures Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox