From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759068AbcILNFL (ORCPT ); Mon, 12 Sep 2016 09:05:11 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34536 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758717AbcILNE0 (ORCPT ); Mon, 12 Sep 2016 09:04:26 -0400 Date: Mon, 12 Sep 2016 21:04:44 +0800 From: Phidias Chiang To: Mika Westerberg Cc: Anisse Astier , Linus Walleij , Heikki Krogerus , Yu C Chen , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Message-ID: <20160912130444.GB2411@ktx> References: <20160818135813.GJ30827@lahna.fi.intel.com> <20160908101303.GA22716@ktx> <20160908102402.GC15313@lahna.fi.intel.com> <20160908162843.GB22716@ktx> <20160909061834.GG15313@lahna.fi.intel.com> <20160909082358.GA23895@ktx> <20160909085832.GK15313@lahna.fi.intel.com> <20160911080506.GO15313@lahna.fi.intel.com> <20160912065656.GA2411@ktx> <20160912090401.GB1811@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160912090401.GB1811@lahna.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 12:04:01PM +0300, Mika Westerberg wrote: > > OK, I see what is going on now. When I changed handle_simple_irq to > handle_bad_irq, the IRQ core in __irq_do_set_handler() thinks the > handler is uninstalled and masks the line. > > If you change handle_bad_irq to handle_simple_irq, in call to > gpiochip_irqchip_add(), does it work then? Yes it does :), thank you for the support!