From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933095AbcILNwy (ORCPT ); Mon, 12 Sep 2016 09:52:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:2580 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933053AbcILNwx (ORCPT ); Mon, 12 Sep 2016 09:52:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,322,1470726000"; d="scan'208";a="759840974" Date: Mon, 12 Sep 2016 16:43:53 +0300 From: Mika Westerberg To: Jarkko Nikula Cc: linux-kernel@vger.kernel.org, Lee Jones , Paul Liu , Andy Shevchenko Subject: Re: [PATCH] mfd: intel-lpss: Add default I2C device properties for Apollo Lake Message-ID: <20160912134353.GH1811@lahna.fi.intel.com> References: <20160912114133.7038-1-jarkko.nikula@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912114133.7038-1-jarkko.nikula@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 02:41:33PM +0300, Jarkko Nikula wrote: > Default I2C device properties for Intel Broxton, especially SDA hold time > may not be enough on Intel Apollo Lake. These properties are used in case > we don't get timing parameters from ACPI. > > The default SDA hold time for Broxton may fail with arbitration lost errors > on Apollo Lake: > > i2c_designware i2c_designware.1: i2c_dw_handle_tx_abort: lost arbitration > > Fix this by using different default device properties on Apollo Lake than > Broxton. > > Reported-by: Paul Liu > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=156181 > Signed-off-by: Jarkko Nikula Acked-by: Mika Westerberg