* [PATCH] rpmsg: smd: fix dependency on QCOM_SMD=n
@ 2016-09-12 9:58 Arnd Bergmann
2016-09-12 14:06 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-09-12 9:58 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson
Cc: Arnd Bergmann, linux-remoteproc, linux-kernel
The ARM allmodconfig build broke with the addition of the SMD rpmsg
driver that conflicts with the driver its replaces:
WARNING: drivers/soc/qcom/smd: 'qcom_smd_register_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko
WARNING: drivers/soc/qcom/smd: 'qcom_smd_unregister_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko
There is already a dependency that is meant to avoid the broken
configuration, but that only prevents the case where at least
one of the two are built-in, but not if both are modules.
This changes the dependency to "=n", to ensure that the new driver
can only be enabled if the other one is completely disabled.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
---
drivers/rpmsg/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
index 9ba5a2e5c930..de31c5f14dd9 100644
--- a/drivers/rpmsg/Kconfig
+++ b/drivers/rpmsg/Kconfig
@@ -7,7 +7,7 @@ config RPMSG
config RPMSG_QCOM_SMD
tristate "Qualcomm Shared Memory Driver (SMD)"
depends on QCOM_SMEM
- depends on !QCOM_SMD
+ depends on QCOM_SMD=n
select RPMSG
help
Say y here to enable support for the Qualcomm Shared Memory Driver
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rpmsg: smd: fix dependency on QCOM_SMD=n
2016-09-12 9:58 [PATCH] rpmsg: smd: fix dependency on QCOM_SMD=n Arnd Bergmann
@ 2016-09-12 14:06 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2016-09-12 14:06 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Ohad Ben-Cohen, linux-remoteproc, linux-kernel
On Mon 12 Sep 02:58 PDT 2016, Arnd Bergmann wrote:
> The ARM allmodconfig build broke with the addition of the SMD rpmsg
> driver that conflicts with the driver its replaces:
>
> WARNING: drivers/soc/qcom/smd: 'qcom_smd_register_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko
> WARNING: drivers/soc/qcom/smd: 'qcom_smd_unregister_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko
>
> There is already a dependency that is meant to avoid the broken
> configuration, but that only prevents the case where at least
> one of the two are built-in, but not if both are modules.
>
> This changes the dependency to "=n", to ensure that the new driver
> can only be enabled if the other one is completely disabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
> ---
> drivers/rpmsg/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
> index 9ba5a2e5c930..de31c5f14dd9 100644
> --- a/drivers/rpmsg/Kconfig
> +++ b/drivers/rpmsg/Kconfig
> @@ -7,7 +7,7 @@ config RPMSG
> config RPMSG_QCOM_SMD
> tristate "Qualcomm Shared Memory Driver (SMD)"
> depends on QCOM_SMEM
> - depends on !QCOM_SMD
> + depends on QCOM_SMD=n
> select RPMSG
> help
> Say y here to enable support for the Qualcomm Shared Memory Driver
Of course, time to study this grammar again...
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-12 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 9:58 [PATCH] rpmsg: smd: fix dependency on QCOM_SMD=n Arnd Bergmann
2016-09-12 14:06 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox