From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933659AbcILOGs (ORCPT ); Mon, 12 Sep 2016 10:06:48 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35223 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933610AbcILOGg (ORCPT ); Mon, 12 Sep 2016 10:06:36 -0400 Date: Mon, 12 Sep 2016 07:06:32 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rpmsg: smd: fix dependency on QCOM_SMD=n Message-ID: <20160912140632.GG405@tuxbot> References: <20160912095903.897647-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912095903.897647-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 12 Sep 02:58 PDT 2016, Arnd Bergmann wrote: > The ARM allmodconfig build broke with the addition of the SMD rpmsg > driver that conflicts with the driver its replaces: > > WARNING: drivers/soc/qcom/smd: 'qcom_smd_register_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko > WARNING: drivers/soc/qcom/smd: 'qcom_smd_unregister_edge' exported twice. Previous export was in drivers/rpmsg/qcom_smd.ko > > There is already a dependency that is meant to avoid the broken > configuration, but that only prevents the case where at least > one of the two are built-in, but not if both are modules. > > This changes the dependency to "=n", to ensure that the new driver > can only be enabled if the other one is completely disabled. > > Signed-off-by: Arnd Bergmann > Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") > --- > drivers/rpmsg/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig > index 9ba5a2e5c930..de31c5f14dd9 100644 > --- a/drivers/rpmsg/Kconfig > +++ b/drivers/rpmsg/Kconfig > @@ -7,7 +7,7 @@ config RPMSG > config RPMSG_QCOM_SMD > tristate "Qualcomm Shared Memory Driver (SMD)" > depends on QCOM_SMEM > - depends on !QCOM_SMD > + depends on QCOM_SMD=n > select RPMSG > help > Say y here to enable support for the Qualcomm Shared Memory Driver Of course, time to study this grammar again... Thanks, Bjorn