From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933194AbcILO1o (ORCPT ); Mon, 12 Sep 2016 10:27:44 -0400 Received: from mail.kernel.org ([198.145.29.136]:54108 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbcILO1m (ORCPT ); Mon, 12 Sep 2016 10:27:42 -0400 Date: Mon, 12 Sep 2016 11:27:28 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen Subject: Re: [PATCH 5/7] perf ui/stdio: Reset output width for hierarchy Message-ID: <20160912142728.GD4897@kernel.org> References: <20160912061958.16656-1-namhyung@kernel.org> <20160912061958.16656-6-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912061958.16656-6-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Sep 12, 2016 at 03:19:56PM +0900, Namhyung Kim escreveu: > When --hierarchy option is used, each entry has its own hpp_list to show > the result. But it missed to update width of each column. Missing "Fixes:" tag? This is important for the stable series, that IIRC uses those tags to semi-automatically figure out what should be picked. - Arnaldo > Signed-off-by: Namhyung Kim > --- > tools/perf/ui/stdio/hist.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/perf/ui/stdio/hist.c b/tools/perf/ui/stdio/hist.c > index 9b65f4a6b35a..83ca728b6f61 100644 > --- a/tools/perf/ui/stdio/hist.c > +++ b/tools/perf/ui/stdio/hist.c > @@ -733,6 +733,7 @@ size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows, > bool use_callchain) > { > struct perf_hpp_fmt *fmt; > + struct perf_hpp_list_node *node; > struct rb_node *nd; > size_t ret = 0; > const char *sep = symbol_conf.field_sep; > @@ -745,6 +746,11 @@ size_t hists__fprintf(struct hists *hists, bool show_header, int max_rows, > > hists__for_each_format(hists, fmt) > perf_hpp__reset_width(fmt, hists); > + /* hierarchy entries have their own hpp list */ > + list_for_each_entry(node, &hists->hpp_formats, list) { > + perf_hpp_list__for_each_format(&node->hpp, fmt) > + perf_hpp__reset_width(fmt, hists); > + } > > if (symbol_conf.col_width_list_str) > perf_hpp__set_user_width(symbol_conf.col_width_list_str); > -- > 2.9.3