linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 7/7] perf report: Enable group view with hierarchy
Date: Mon, 12 Sep 2016 11:28:44 -0300	[thread overview]
Message-ID: <20160912142844.GF4897@kernel.org> (raw)
In-Reply-To: <20160912061958.16656-8-namhyung@kernel.org>

Em Mon, Sep 12, 2016 at 03:19:58PM +0900, Namhyung Kim escreveu:
> Now all missing pieces are implemented, let's enable it.  An example
> output below:

So. what are those events? What was the command line that produced the
'perf.data' file that was used?

- Arnaldo
 
>   $ perf report --hierarchy --stdio
>   ...
>   #               Overhead  Command / Shared Object / Symbol
>   # ......................  ..................................
>   #
>       25.74%  27.18%        sh
>          19.96%  24.14%        libc-2.24.so
>             9.55%  14.64%        [.] __strcmp_sse2
>             1.54%   0.00%        [.] __tfind
>             1.07%   1.13%        [.] _int_malloc
>             0.95%   0.00%        [.] __strchr_sse2
>             0.89%   1.39%        [.] __tsearch
>             0.76%   0.00%        [.] strlen
>   ...
> 
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>  tools/perf/builtin-report.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 1a07c4cdf6ed..6e88460cd13d 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -935,7 +935,6 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
>  
>  	if (symbol_conf.report_hierarchy) {
>  		/* disable incompatible options */
> -		symbol_conf.event_group = false;
>  		symbol_conf.cumulate_callchain = false;
>  
>  		if (field_order) {
> -- 
> 2.9.3

  reply	other threads:[~2016-09-12 14:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  6:19 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v1) Namhyung Kim
2016-09-12  6:19 ` [PATCH 1/7] perf hists browser: Fix event group display Namhyung Kim
2016-09-12 14:23   ` Arnaldo Carvalho de Melo
2016-09-20 21:37   ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-09-12  6:19 ` [PATCH 2/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim
2016-09-12 14:25   ` Arnaldo Carvalho de Melo
2016-09-12 23:59     ` Namhyung Kim
2016-09-12  6:19 ` [PATCH 3/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim
2016-09-12  6:19 ` [PATCH 4/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim
2016-09-12 14:22   ` Arnaldo Carvalho de Melo
2016-09-13  0:09     ` Namhyung Kim
2016-09-12  6:19 ` [PATCH 5/7] perf ui/stdio: Reset output width for hierarchy Namhyung Kim
2016-09-12 14:27   ` Arnaldo Carvalho de Melo
2016-09-13  1:00     ` Namhyung Kim
2016-09-12  6:19 ` [PATCH 6/7] perf ui/tui: " Namhyung Kim
2016-09-12 14:27   ` Arnaldo Carvalho de Melo
2016-09-13  1:01     ` Namhyung Kim
2016-09-12  6:19 ` [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim
2016-09-12 14:28   ` Arnaldo Carvalho de Melo [this message]
2016-09-13  1:06     ` Namhyung Kim
  -- strict thread matches above, loose matches on Subject: below --
2016-09-13  7:45 [PATCHSET 0/7] perf tools: Support hierarchy report with event group (v2) Namhyung Kim
2016-09-13  7:45 ` [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912142844.GF4897@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).