From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: linux-kernel@vger.kernel.org, lizefan@huawei.com, pi3orama@163.com
Subject: Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture
Date: Mon, 12 Sep 2016 18:15:20 -0300 [thread overview]
Message-ID: <20160912211520.GA10582@kernel.org> (raw)
In-Reply-To: <20160912190742.GG4897@kernel.org>
Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Sep 12, 2016 at 12:54:29PM +0000, Wang Nan escreveu:
> > Some mmap related macros have different values for different
> > architectures. This patch introduces uapi mman.h for each
> > architectures.
> >
> > Three headers are cloned from kernel include to tools/include:
> >
> > tools/include/uapi/asm-generic/mman-common.h
> > tools/include/uapi/asm-generic/mman.h
> > tools/include/uapi/linux/mman.h
>
> Cool, the above was done as copies, why not the rest? IIRC you mentioned
> some reasoning behind that decision, but we need it spelled out here.
>
> For instance, I went on and look at arch/xtensa/include/uapi/asm/mman.h,
> and couldn't find why we shouldn't copy it just like the three files
> above.
>
> I'm looking now at why the build breaks in so many systems, first hunch
> is that bits/ part (the ones without the failure details probably have
> the same errors), alpine uses musl libc, but some that broke are glibc
> based.
So, please take a look at my perf/core branch, I applied 1/3 and 3/3,
but took a different path for 2/3, now it builds for all systems I have
containers for:
# time dm
1 67.700 alpine:3.4: Ok
2 23.565 android-ndk:r12b-arm: Ok
3 67.823 archlinux:latest: Ok
4 37.277 centos:5: Ok
5 57.621 centos:6: Ok
6 68.348 centos:7: Ok
7 61.971 debian:7: Ok
8 65.711 debian:8: Ok
9 36.894 debian:experimental: Ok
10 66.274 fedora:20: Ok
11 70.054 fedora:21: Ok
12 68.310 fedora:22: Ok
13 68.033 fedora:23: Ok
14 72.322 fedora:24: Ok
15 29.529 fedora:24-x-ARC-uClibc: Ok
16 77.458 fedora:rawhide: Ok
17 80.110 mageia:5: Ok
18 72.664 opensuse:13.2: Ok
19 70.878 opensuse:42.1: Ok
20 80.322 opensuse:tumbleweed: Ok
21 62.237 ubuntu:12.04.5: Ok
22 39.998 ubuntu:14.04: Ok
23 69.383 ubuntu:14.04.4: Ok
24 76.120 ubuntu:15.10: Ok
25 69.668 ubuntu:16.04: Ok
26 69.061 ubuntu:16.04-x-arm: Ok
27 73.337 ubuntu:16.04-x-arm64: Ok
28 77.061 ubuntu:16.04-x-powerpc64: Ok
29 55.340 ubuntu:16.04-x-powerpc64el: Ok
30 85.579 ubuntu:16.10: Ok
31 59.645 ubuntu:16.10-x-s390: Ok
real 32m59.385s
user 0m1.856s
sys 0m2.077s
#
next prev parent reply other threads:[~2016-09-12 21:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 12:54 [PATCH 0/3] perf: Fix mmap related macros Wang Nan
2016-09-12 12:54 ` [PATCH 1/3] tools include: Add uapi mman.h for each architecture Wang Nan
2016-09-12 19:07 ` Arnaldo Carvalho de Melo
2016-09-12 21:15 ` Arnaldo Carvalho de Melo [this message]
2016-09-13 6:36 ` Wangnan (F)
2016-09-14 9:28 ` Naveen N. Rao
2016-09-14 9:36 ` Wangnan (F)
2016-09-14 10:00 ` Naveen N. Rao
2016-09-14 10:23 ` Wangnan (F)
2016-09-14 10:46 ` Naveen N. Rao
2016-09-14 10:49 ` Wangnan (F)
2016-09-14 13:52 ` Arnaldo Carvalho de Melo
2016-09-14 16:34 ` Naveen N. Rao
2016-09-14 17:00 ` Arnaldo Carvalho de Melo
2016-09-15 14:47 ` Naveen N. Rao
2016-09-20 21:37 ` [tip:perf/core] " tip-bot for Wang Nan
2016-09-12 12:54 ` [PATCH 2/3] tools include: Introduce bits/mman.h Wang Nan
2016-09-12 12:54 ` [PATCH 3/3] perf build: Compare mman.h related headers againest kernel Wang Nan
2016-09-20 21:39 ` [tip:perf/core] perf build: Compare mman.h related headers against kernel originals tip-bot for Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912211520.GA10582@kernel.org \
--to=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).