Re: [PATCH 1/8] gpio: palmas: fix implicit assumption module.h is present

Linus Walleij
2016-09-15T11:58:16Z

On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> This file is currently getting module.h from a global gpio header
> and it will fail to build once we remove module.h from that.
>
> However, the driver is controlled with the following Kconfig:
>
> drivers/gpio/Kconfig:config GPIO_PALMAS
> drivers/gpio/Kconfig: bool "TI PALMAS series PMICs GPIO"
>
> and hence the line of MODULE_DEVICE_TABLE is a no-op that can simply
> be deleted. In fact it should have been removed in an earlier commit
> that did demodularization, however the unseen include prevented my
> build testing from detecting it.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij