From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753190AbcIMBBY (ORCPT ); Mon, 12 Sep 2016 21:01:24 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:46020 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752778AbcIMBBX (ORCPT ); Mon, 12 Sep 2016 21:01:23 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Tue, 13 Sep 2016 10:01:17 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen Subject: Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Message-ID: <20160913010117.GD3641@sejong> References: <20160912061958.16656-1-namhyung@kernel.org> <20160912061958.16656-7-namhyung@kernel.org> <20160912142747.GE4897@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160912142747.GE4897@kernel.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 11:27:47AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 12, 2016 at 03:19:57PM +0900, Namhyung Kim escreveu: > > When --hierarchy option is used, each entry has its own hpp_list to show > > the result. But it missed to update width of each column. > > Ditto, missing "Fixes:" tag. It's the same commit. Will add the tag. Thanks, Namhyung > > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/ui/browsers/hists.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > > index 35e44b1879e3..49db16334814 100644 > > --- a/tools/perf/ui/browsers/hists.c > > +++ b/tools/perf/ui/browsers/hists.c > > @@ -2067,6 +2067,7 @@ void hist_browser__init(struct hist_browser *browser, > > struct hists *hists) > > { > > struct perf_hpp_fmt *fmt; > > + struct perf_hpp_list_node *node; > > > > browser->hists = hists; > > browser->b.refresh = hist_browser__refresh; > > @@ -2079,6 +2080,11 @@ void hist_browser__init(struct hist_browser *browser, > > perf_hpp__reset_width(fmt, hists); > > ++browser->b.columns; > > } > > + /* hierarchy entries have their own hpp list */ > > + list_for_each_entry(node, &hists->hpp_formats, list) { > > + perf_hpp_list__for_each_format(&node->hpp, fmt) > > + perf_hpp__reset_width(fmt, hists); > > + } > > } > > > > struct hist_browser *hist_browser__new(struct hists *hists) > > -- > > 2.9.3