From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbcIMBGb (ORCPT ); Mon, 12 Sep 2016 21:06:31 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:52856 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbcIMBG2 (ORCPT ); Mon, 12 Sep 2016 21:06:28 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 165.244.98.76 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org Date: Tue, 13 Sep 2016 10:06:19 +0900 From: Namhyung Kim To: Arnaldo Carvalho de Melo CC: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen Subject: Re: [PATCH 7/7] perf report: Enable group view with hierarchy Message-ID: <20160913010619.GE3641@sejong> References: <20160912061958.16656-1-namhyung@kernel.org> <20160912061958.16656-8-namhyung@kernel.org> <20160912142844.GF4897@kernel.org> MIME-Version: 1.0 In-Reply-To: <20160912142844.GF4897@kernel.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/09/13 10:06:20, Serialize by Router on LGEKRMHUB05/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/09/13 10:06:20, Serialize complete at 2016/09/13 10:06:20 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 11:28:44AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 12, 2016 at 03:19:58PM +0900, Namhyung Kim escreveu: > > Now all missing pieces are implemented, let's enable it. An example > > output below: > > So. what are those events? What was the command line that produced the > 'perf.data' file that was used? Oh, the command line was: $ perf record -e '{cycles,instructions}' make I'll add it to the changelog. Thanks, Namhyung p.s. Actually the most overhead goes to the compiler (cc1) in this data. But I omitted it since it has so many unresolved symbol addresses. I think it's not a problem to demonstrate the hierarchy + group feature. > > - Arnaldo > > > $ perf report --hierarchy --stdio > > ... > > # Overhead Command / Shared Object / Symbol > > # ...................... .................................. > > # > > 25.74% 27.18% sh > > 19.96% 24.14% libc-2.24.so > > 9.55% 14.64% [.] __strcmp_sse2 > > 1.54% 0.00% [.] __tfind > > 1.07% 1.13% [.] _int_malloc > > 0.95% 0.00% [.] __strchr_sse2 > > 0.89% 1.39% [.] __tsearch > > 0.76% 0.00% [.] strlen > > ... > > > > Signed-off-by: Namhyung Kim > > --- > > tools/perf/builtin-report.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > index 1a07c4cdf6ed..6e88460cd13d 100644 > > --- a/tools/perf/builtin-report.c > > +++ b/tools/perf/builtin-report.c > > @@ -935,7 +935,6 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused) > > > > if (symbol_conf.report_hierarchy) { > > /* disable incompatible options */ > > - symbol_conf.event_group = false; > > symbol_conf.cumulate_callchain = false; > > > > if (field_order) { > > -- > > 2.9.3