From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbcIMGcr (ORCPT ); Tue, 13 Sep 2016 02:32:47 -0400 Received: from mail.kernel.org ([198.145.29.136]:44024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbcIMGcp (ORCPT ); Tue, 13 Sep 2016 02:32:45 -0400 Date: Tue, 13 Sep 2016 09:32:40 +0300 From: Leon Romanovsky To: Salil Mehta Cc: dledford@redhat.com, xavier.huwei@huawei.com, oulijun@huawei.com, yisen.zhuang@huawei.com, xuwei5@hisilicon.com, mehta.salil.lnk@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, Peter Chen Subject: Re: [PATCH for-next 16/20] IB/hns: Validate mtu when modified qp Message-ID: <20160913063240.GO8812@leon.nu> References: <1473417051-99560-1-git-send-email-salil.mehta@huawei.com> <1473417051-99560-17-git-send-email-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DITGHUV3p5DjDsXt" Content-Disposition: inline In-Reply-To: <1473417051-99560-17-git-send-email-salil.mehta@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DITGHUV3p5DjDsXt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 09, 2016 at 06:30:47PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The mtu should be validated when modify qp,so we check it. > > Signed-off-by: Lijun Ou > Signed-off-by: Peter Chen > Reviewed-by: Wei Hu (Xavier) > Signed-off-by: Salil Mehta > --- > drivers/infiniband/hw/hns/hns_roce_qp.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c > index 51fefbf..1c5be59 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_qp.c > +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c > @@ -32,6 +32,7 @@ > */ > > #include > +#include > #include > #include "hns_roce_common.h" > #include "hns_roce_device.h" > @@ -658,6 +659,7 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, > struct device *dev = &hr_dev->pdev->dev; > int ret = -EINVAL; > int p; > + u32 active_mtu = 0; There is no need to assign value to a variable which will be overwritten. > > mutex_lock(&hr_qp->mutex); > > @@ -688,6 +690,19 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, > } > } > > + if (attr_mask & IB_QP_PATH_MTU) { > + p = attr_mask & IB_QP_PORT ? (attr->port_num - 1) : hr_qp->port; > + active_mtu = iboe_get_mtu(hr_dev->iboe.netdevs[p]->mtu); ib_mtu iboe_get_mtu returns "enum ib_mtu" and not u32. > + > + if (attr->path_mtu > IB_MTU_2048 || > + attr->path_mtu < IB_MTU_256 || > + attr->path_mtu > active_mtu) { > + dev_err(dev, "attr path_mtu(%d)invalid while modify qp", > + attr->path_mtu); > + goto out; > + } > + } > + > if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC && > attr->max_rd_atomic > hr_dev->caps.max_qp_init_rdma) { > dev_err(dev, "attr max_rd_atomic invalid.attr->max_rd_atomic=%d\n", > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --DITGHUV3p5DjDsXt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX152IAAoJEORje4g2clinewQP/0xn4I8jAg8vBaTHMb3k2N14 lPOvq6o1fUPE0Ix+PoAPtQLbnPnrAXRzRZcv0MqTZQeO/v1aejlzGtp+OVzIU149 95sOUj3/VbxkWoLN+BOSzA1yWIvp2C45Y9RIJ8N4eSOljPwVwADcjBIbnh/0xlhK FqSYA/UdI3csxdynVzYQq7/tJekAt4iG3vC0yMMzm8JlaFuCGpUR++Twy85UeXVu ScOOQjmn6AokkvnMDiD7gUGFlMrfmBxfpzxBCoKdBiF85EyVRCbLLhljLdJRHdea Rtrtooc676d4gK3orzLLV5BZ2JrGhxcPNJhLZAhS85ILN9TtLFI+eb6hxUDikec1 52pfoIKYByM1LWtljj+pgGkP9MsTqKM5evEM8Yra0ZMbwOHrjxLCBUDuWkrsnsr4 LQezUbmc3IkEOyWxb+G1GEJ1v0VzJln+AgJREeu9TnBP4uRvyjobmEjMCMyM76mw cRJa8j9G1VFBpReoqQ7JscbaV/FB+BrvNpL01frEFFUakUuyJK9zz6fXdyHUwDWQ QdB/UvxmLx/e0s8DJJkBrRrkynjMUyXTxaWIXu8yjaILK0PX2DXw6rvqG9jdflJZ /YsG3chbg8h+Kz/Z173fTK4SrvZpsAnR9cN4dF3DFj0h4dlnmrxAEOC0rt4j8Hrj TMPzPiS+trh/Nuic3ODn =5Q1g -----END PGP SIGNATURE----- --DITGHUV3p5DjDsXt--