Re: [PATCH] android: binder: Disable preemption while holding the global binder lock

kbuild test robot
2016-09-09T16:37:41Z

[-- Attachment #1: Type: text/plain, Size: 4386 bytes --]

Hi Todd,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.8-rc5 next-20160909]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/Todd-Kjos/android-binder-Disable-preemption-while-holding-the-global-binder-lock/20160909-233333
config: x86_64-randconfig-x008-201636 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/android/binder.c: In function 'binder_thread_read':
>> drivers/android/binder.c:2432:4: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
else
^~~~
drivers/android/binder.c:2434:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else'
if (put_user_nopreempt(cmd,
^~

vim +/else +2432 drivers/android/binder.c

da49889d drivers/staging/android/binder.c Arve Hjønnevåg 2014-02-21 2416 proc->pid, thread->pid,
da49889d drivers/staging/android/binder.c Arve Hjønnevåg 2014-02-21 2417 node->debug_id,
da49889d drivers/staging/android/binder.c Arve Hjønnevåg 2014-02-21 2418 (u64)node->ptr,
da49889d drivers/staging/android/binder.c Arve Hjønnevåg 2014-02-21 2419 (u64)node->cookie);
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2420 }
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2421 }
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2422 } break;
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2423 case BINDER_WORK_DEAD_BINDER:
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2424 case BINDER_WORK_DEAD_BINDER_AND_CLEAR:
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2425 case BINDER_WORK_CLEAR_DEATH_NOTIFICATION: {
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2426 struct binder_ref_death *death;
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2427 uint32_t cmd;
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2428
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2429 death = container_of(w, struct binder_ref_death, work);
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2430 if (w->type == BINDER_WORK_CLEAR_DEATH_NOTIFICATION)
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2431 cmd = BR_CLEAR_DEATH_NOTIFICATION_DONE;
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 @2432 else
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2433 cmd = BR_DEAD_BINDER;
ddd4adb7 drivers/android/binder.c Todd Kjos 2016-09-09 2434 if (put_user_nopreempt(cmd,
ddd4adb7 drivers/android/binder.c Todd Kjos 2016-09-09 2435 (uint32_t __user *) ptr))
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2436 return -EFAULT;
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2437 ptr += sizeof(uint32_t);
ddd4adb7 drivers/android/binder.c Todd Kjos 2016-09-09 2438 if (put_user_nopreempt(death->cookie,
da49889d drivers/staging/android/binder.c Arve Hjønnevåg 2014-02-21 2439 (binder_uintptr_t __user *) ptr))
355b0502 drivers/staging/android/binder.c Greg Kroah-Hartman 2011-11-30 2440 return -EFAULT;

:::::: The code at line 2432 was first introduced by commit
:::::: 355b0502f6efea0ff9492753888772c96972d2a3 Revert "Staging: android: delete android drivers"

:::::: TO: Greg Kroah-Hartman <gregkh@suse.de>
:::::: CC: Greg Kroah-Hartman <gregkh@suse.de>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 21144 bytes --]