From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754992AbcIMGrj (ORCPT ); Tue, 13 Sep 2016 02:47:39 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54456 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbcIMGri (ORCPT ); Tue, 13 Sep 2016 02:47:38 -0400 Date: Tue, 13 Sep 2016 08:47:29 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Li Yang Cc: Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gao Pan Subject: Re: [PATCH v7] i2c: imx: make bus recovery through pinctrl optional Message-ID: <20160913064729.6jtwlpkpi36gxtpj@pengutronix.de> References: <1473718950-6667-1-git-send-email-leoyang.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1473718950-6667-1-git-send-email-leoyang.li@nxp.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 05:22:30PM -0500, Li Yang wrote: > Since commit 1c4b6c3bcf30 ("i2c: imx: implement bus recovery") the > driver starts to use gpio/pinctrl to support optional bus recovery > feature. But pinctrl is not always usable. There are platforms such > as ls1021a and ls1043a that don't support pinctrl, and it could just > be broken due to old/broken device tree. The patch makes it really > optional that the probe function won't bailout on pinctrl problems > instead it just disables bus recovery and prints out notification when > there is problem with pinctrl. Since pinctrl is only used by bus > recovery in this driver, move pinctrl initialization into bus recovery > init function to prevent confusion. > > Signed-off-by: Li Yang > Cc: Gao Pan > Cc: Uwe Kleine-König Acked-by: Uwe Kleine-König > Acked-by: Linus Walleij -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |