Re: [PATCH V5] clk: bcm: Add driver for BCM53573 ILP clock

Stephen Boyd
2016-08-25T19:58:29Z

On 08/25, Rafał Miłecki wrote:
> On 24 August 2016 at 10:47, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 08/23, Rafał Miłecki wrote:
> >> +static int bcm53573_ilp_enable(struct clk_hw *hw)
> >> +{
> >> + struct bcm53573_ilp *ilp = container_of(hw, struct bcm53573_ilp, hw);
> >> +
> >> + writel(0x10199, ilp->pmu + PMU_SLOW_CLK_PERIOD);
> >> + writel(0x10000, ilp->pmu + 0x674);
> >
> > Is there a name for 0x674?
>
> No in any sources published by Broadcom. I was experimenting with bit
> 0x10000 in PMU_SLOW_CLK_PERIOD and 0x10000 in 0x674. Both have to be
> set. I was suspecting that maybe one of them is just some trigger and
> it can be switched back to 0, but it's not the case. I definitely need
> to set both of them to get clock working.

Ok no worries, raw number is fine.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project