From: Lee Jones <lee.jones@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
Florian Lobmaier <florian.lobmaier@ams.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH 2/6] mfd: as3722: convert MFD_AS3722 from bool to tristate
Date: Tue, 13 Sep 2016 09:52:25 +0100 [thread overview]
Message-ID: <20160913085225.GB24465@dell> (raw)
In-Reply-To: <20160912144054.27522-3-paul.gortmaker@windriver.com>
On Mon, 12 Sep 2016, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_AS3722
> drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> In response to an earlier patch set suggesting removal of the unused
> modular code, Laxman suggested that this driver be instead moved to
> tristate.
>
> We do that here, and confirm it can build and modpost as a tristate.
> However there remains to be runtime testing in order to ensure this
> change is 100% functional for "=m".
>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Florian Lobmaier <florian.lobmaier@ams.com>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 9ac9f6250ba8..9a529bf06eed 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -50,7 +50,7 @@ config MFD_AS3711
> Support for the AS3711 PMIC from AMS
>
> config MFD_AS3722
> - bool "ams AS3722 Power Management IC"
> + tristate "ams AS3722 Power Management IC"
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-09-13 8:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 14:40 [PATCH v2 0/6] mfd: trivial demodularization of non-modular drivers Paul Gortmaker
2016-09-12 14:40 ` [PATCH 1/6] mfd: altera-a10sr: make it explicitly non-modular Paul Gortmaker
2016-09-13 8:52 ` Lee Jones
2016-09-12 14:40 ` [PATCH 2/6] mfd: as3722: convert MFD_AS3722 from bool to tristate Paul Gortmaker
2016-09-13 8:52 ` Lee Jones [this message]
2016-09-12 14:40 ` [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular Paul Gortmaker
2016-09-13 8:52 ` Lee Jones
2016-09-12 14:40 ` [PATCH 4/6] mfd: smsc-ece1099: " Paul Gortmaker
2016-09-13 8:52 ` Lee Jones
2016-09-12 14:40 ` [PATCH 5/6] mfd: sun6i-prcm: " Paul Gortmaker
2016-09-12 17:43 ` Boris Brezillon
2016-09-13 8:53 ` Lee Jones
2016-09-12 14:40 ` [PATCH 6/6] mfd: twl-core: " Paul Gortmaker
2016-09-13 3:26 ` Tony Lindgren
2016-09-13 8:53 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160913085225.GB24465@dell \
--to=lee.jones@linaro.org \
--cc=florian.lobmaier@ams.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox