From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757123AbcIMNiX (ORCPT ); Tue, 13 Sep 2016 09:38:23 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33155 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbcIMNiU (ORCPT ); Tue, 13 Sep 2016 09:38:20 -0400 Date: Tue, 13 Sep 2016 15:38:14 +0200 From: LABBE Corentin To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module Message-ID: <20160913133814.GD31990@Red> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-5-git-send-email-clabbe.montjoie@gmail.com> <20160912072812.GB9449@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912072812.GB9449@lukather> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2016 at 09:28:12AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in this syscon and the only one useful is > > the one dedicated to EMAC clock. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > > index fdf9fdb..a39da6f 100644 > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > @@ -140,6 +140,11 @@ > > #size-cells = <1>; > > ranges; > > > > + syscon: syscon@01c00000 { > > + compatible = "syscon"; > > Having our compatible would be nice here. syscon doesn't mean anything > by itself. > Since no driver handle it, I follow what I saw in other DT. At your choice, I can add a sun8i-syscon, but it will be unused. > > + reg = <0x01c00000 0x34>; > > And the size of our system controller is 0x1000 > I put the real size used, but I can put what datasheet said. Regards Corentin Labbe