From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758704AbcIMOq2 (ORCPT ); Tue, 13 Sep 2016 10:46:28 -0400 Received: from mail5.windriver.com ([192.103.53.11]:48886 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758429AbcIMOqX (ORCPT ); Tue, 13 Sep 2016 10:46:23 -0400 Date: Tue, 13 Sep 2016 10:46:17 -0400 From: Paul Gortmaker To: Andy Shevchenko CC: Bin Gao , Mika Westerberg , Mathias Nyman , Linus Walleij , Alexandre Courbot , "linux-gpio@vger.kernel.org" , LKML , Ajay Thomas , Yegnesh S Iyer , Bin Gao Subject: Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver Message-ID: <20160913144617.GL28311@windriver.com> References: <20160725215938.GC211765@worksta> <20160913133726.GI28311@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 17:35) Andy Shevchenko wrote: > On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker > wrote: > >> > This looks like an invalid address, and .... > >> > >> >> +MODULE_AUTHOR("Ajay Thomas "); > >> > > >> > ...the same here. In fact it sure looks like two names. Anyway I just got a > >> > bounce when I tried to use it... > >> > >> It might be that person is no longer working for Intel, though I think > >> It would be better log message for that. > > > > That might make sense if the driver was old, but it hasn't even hit > > mainline yet -- it is only in linux-next, so it cant be more than a few > > weeks old. > > It's already quite off topic, so, I would just say that it is still > valid point. Starting from some version of the series (which takes > couple of months?) Bin Gao did improvements. Not sure why you would call it off topic -- a new driver appearing in mainline should have a valid author entry, and if it is an accidental merge of two names into one then Bin Gao is the person who can ack that and subsequently fix it. P. -- > > -- > With Best Regards, > Andy Shevchenko