From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758875AbcIMQC6 (ORCPT ); Tue, 13 Sep 2016 12:02:58 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:42410 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754811AbcIMQC4 (ORCPT ); Tue, 13 Sep 2016 12:02:56 -0400 Date: Tue, 13 Sep 2016 18:02:52 +0200 From: Ralf Baechle To: Matt Redfearn Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port Message-ID: <20160913160251.GC20655@linux-mips.org> References: <1473092320-30019-1-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473092320-30019-1-git-send-email-matt.redfearn@imgtec.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 05, 2016 at 05:18:40PM +0100, Matt Redfearn wrote: > If the rb532 machine is compiled without CONFIG_SERIAL_8250, the > following linker error occurs > > arch/mips/built-in.o: In function `setup_serial_port': > (.init.text+0x20c): undefined reference to `early_serial_setup' > > Fix this by wrapping registration of the rb532 uart in an ifdef > CONFIG_SERIAL_8250. This will still fail if CONFIG_SERIAL_8250 = m. RB532 should be rewritten to use earl console rather than early_serial_setup similar to https://git.linux-mips.org/cgit/ralf/linux.git/commit/?id=194d315da86af504559a8a21026360097575bd55 for example. Ralf