From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759901AbcIMSf4 (ORCPT ); Tue, 13 Sep 2016 14:35:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36837 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbcIMSfz (ORCPT ); Tue, 13 Sep 2016 14:35:55 -0400 Date: Tue, 13 Sep 2016 20:35:51 +0200 From: Ingo Molnar To: Steven Rostedt Cc: Colin King , Ingo Molnar , linux-kernel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] tracing/syscalls: add in missing white space in error message text Message-ID: <20160913183551.GA32416@gmail.com> References: <20160912114127.30980-1-colin.king@canonical.com> <20160912094333.4a8dd78b@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912094333.4a8dd78b@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > On Mon, 12 Sep 2016 12:41:27 +0100 > Colin King wrote: > > > From: Colin Ian King > > > > pr_info message spans two lines and the literal string is missing > > a white space between words. Add the white space. > > > > Signed-off-by: Colin Ian King > > --- > > kernel/trace/trace_syscalls.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c > > index b2b6efc..79d8752 100644 > > --- a/kernel/trace/trace_syscalls.c > > +++ b/kernel/trace/trace_syscalls.c > > @@ -610,7 +610,7 @@ static int perf_sysenter_enable(struct trace_event_call *call) > > if (!sys_perf_refcount_enter) > > ret = register_trace_sys_enter(perf_syscall_enter, NULL); > > if (ret) { > > - pr_info("event trace: Could not activate" > > + pr_info("event trace: Could not activate " > > "syscall entry trace point"); > > Actually, the better fix is to make this one line. The 80 character > limit is not applicable when it cuts strings in half, especially when > it causes bugs like this. > > Also, this should go through trivial (with an ack from us). Agreed that user visible strings should be on a single line. With that change: Acked-by: Ingo Molnar Thanks, Ingo