From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759974AbcIMShd (ORCPT ); Tue, 13 Sep 2016 14:37:33 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37841 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755539AbcIMShb (ORCPT ); Tue, 13 Sep 2016 14:37:31 -0400 Date: Tue, 13 Sep 2016 20:37:27 +0200 From: Ingo Molnar To: Christoph Hellwig Cc: sstabellini@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, jgross@suse.com, x86@kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH] xen: consolidate swiotbl_xen dma_ops Message-ID: <20160913183726.GB32416@gmail.com> References: <1473611708-25179-1-git-send-email-hch@lst.de> <20160912114539.GB7597@gmail.com> <20160912145146.GA27766@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160912145146.GA27766@lst.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Christoph Hellwig wrote: > On Mon, Sep 12, 2016 at 01:45:40PM +0200, Ingo Molnar wrote: > > Please organize such initializers better! Something like this: > > > Makes it much easier to review such definitions. > > That's my personal preference, too. But this is just moving/consolidating > code, so I don't plan to do fancy moves. I can be passive-aggressive too, so: NAKed-by: Ingo Molnar If the ugliness that makes the patch much harder to review than it should be is fixed in the same patch or in a different patch then: Acked-by: Ingo Molnar Thanks, Ingo