From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757971AbcIMVmz (ORCPT ); Tue, 13 Sep 2016 17:42:55 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:36950 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbcIMVmy (ORCPT ); Tue, 13 Sep 2016 17:42:54 -0400 Date: Tue, 13 Sep 2016 23:42:44 +0200 From: Peter Zijlstra To: Byungchul Park Cc: Byungchul Park , Ingo Molnar , tglx@linutronix.de, walken@google.com, boqun.feng@gmail.com, kirill@shutemov.name, "linux-kernel@vger.kernel.org" , linux-mm@kvack.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, npiggin@gmail.com Subject: Re: [PATCH v3 07/15] lockdep: Implement crossrelease feature Message-ID: <20160913214244.GB5020@twins.programming.kicks-ass.net> References: <1473759914-17003-1-git-send-email-byungchul.park@lge.com> <1473759914-17003-8-git-send-email-byungchul.park@lge.com> <20160913150554.GI2794@worktop> <20160913193829.GA5016@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160913193829.GA5016@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 09:38:29PM +0200, Peter Zijlstra wrote: > > > I _think_ you propose to keep track of all prior held locks and then use > > > the union of the held list on the block-chain with the prior held list > > > from the complete context. > > > > Almost right. Only thing we need to do to consider the union is to > > connect two chains of two contexts by adding one dependency 'b -> a'. > > Sure, but how do you arrive at which connection to make. The document is > entirely silent on this crucial point. > > The union between the held-locks of the blocked and prev-held-locks of > the release should give a fair indication I think, but then, I've not > thought too hard on this yet. s/union/intersection/ those that are in both sets.