From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760122AbcINIfy (ORCPT ); Wed, 14 Sep 2016 04:35:54 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38795 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbcINIfv (ORCPT ); Wed, 14 Sep 2016 04:35:51 -0400 Date: Wed, 14 Sep 2016 09:37:48 +0100 From: Lee Jones To: Arnd Bergmann Cc: Tony Lindgren , Marcin Niestroj , Grygorii Strashko , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: tps65217: fix nonstandard declaration Message-ID: <20160914083748.GB638@dell> References: <20160914081402.802116-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160914081402.802116-1-arnd@arndb.de> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2016, Arnd Bergmann wrote: > The tps65217 gained a new warning when building with W=1: > > drivers/mfd/tps65217.c:85:1: error: 'inline' is not at beginning of declaration [-Werror=old-style-declaration] > > This fixes it by putting the 'inline' modifier before 'const'. > > Signed-off-by: Arnd Bergmann > Fixes: 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs") > --- > drivers/mfd/tps65217.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. FYI: I plan to fix all W=1 and look at W=2 warnings today anyway. > diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c > index 57c87412106f..9a4d8684dd32 100644 > --- a/drivers/mfd/tps65217.c > +++ b/drivers/mfd/tps65217.c > @@ -82,7 +82,7 @@ static void tps65217_irq_sync_unlock(struct irq_data *data) > mutex_unlock(&tps->irq_lock); > } > > -static const inline struct tps65217_irq * > +static inline const struct tps65217_irq * > irq_to_tps65217_irq(struct tps65217 *tps, struct irq_data *data) > { > return &tps65217_irqs[data->hwirq]; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog