From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data
Date: Wed, 14 Sep 2016 11:44:56 +0200 [thread overview]
Message-ID: <20160914094456.GA5826@kroah.com> (raw)
In-Reply-To: <CACRpkdYSr-4wbsupAPa6Q1nd6THf9YS4TMYa5OqMzF6GNOBMxg@mail.gmail.com>
On Wed, Sep 14, 2016 at 11:06:08AM +0200, Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>
> > irq_get_irq_data() can return NULL, which results in a nasty crash.
> > Check its return value before passing it on to irqd_set_trigger_type().
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Should probably be tagged for stable.
Why, are there any systems that are currently broken without this change
right now?
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-14 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 3:32 [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data Guenter Roeck
2016-09-14 9:06 ` Linus Walleij
2016-09-14 9:44 ` Greg Kroah-Hartman [this message]
2016-09-14 11:12 ` Linus Walleij
2016-09-14 14:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914094456.GA5826@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).