From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761639AbcINLVC (ORCPT ); Wed, 14 Sep 2016 07:21:02 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38752 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758398AbcINLU7 (ORCPT ); Wed, 14 Sep 2016 07:20:59 -0400 Date: Wed, 14 Sep 2016 12:22:57 +0100 From: Lee Jones To: Andy Yan Cc: Arnd Bergmann , Wadim Egorov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rk808: fix RK818_IRQ_DISCHG_ILIM initializer Message-ID: <20160914112257.GD638@dell> References: <20160906131351.1845848-1-arnd@arndb.de> <20160913104826.GB26864@dell> <17d9ef19-7760-c38f-8a72-b3427369c2cc@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17d9ef19-7760-c38f-8a72-b3427369c2cc@rock-chips.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Sep 2016, Andy Yan wrote: > On 2016年09月13日 18:48, Lee Jones wrote: > > On Tue, 06 Sep 2016, Arnd Bergmann wrote: > > > > > When building with -Woverride-init, we get a warning about an incorrect > > > initializer: > > > > > > drivers/mfd/rk808.c:244:8: error: initialized field overwritten [-Werror=override-init] > > > [RK818_IRQ_DISCHG_ILIM] = { > > > > > > This is clearly a mistake, as both RK818_IRQ_DISCHG_ILIM and RK818_IRQ_USB_OV > > > are defined as '7', but they refer to different register bits. Changing > > > RK818_IRQ_DISCHG_ILIM to 15 is consistent with how all other 14 interrupts are > > > handled here, so I'm assuming this is what it should have been. > > > > > > Signed-off-by: Arnd Bergmann > > > Fixes: 2eedcbfc0612 ("mfd: rk808: Add RK818 support") > > > --- > > > include/linux/mfd/rk808.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I would like someone who is in possession of a datasheet to confirm > > this. > > According to the datasheet, the RK818_IRQ_USB_OV is in bit 7 of > INT_STS_REG1(0x4c) and RK818_IRQ_DISCHG_ILIM is in bit 7 of > INT_STS_REG2(0x4e), so Arnd's change is right. I'll take that as an Ack. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog