From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761794AbcINNOE (ORCPT ); Wed, 14 Sep 2016 09:14:04 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46916 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755879AbcINNOD (ORCPT ); Wed, 14 Sep 2016 09:14:03 -0400 Date: Wed, 14 Sep 2016 08:13:38 -0500 From: Bin Liu To: Tony Lindgren CC: kbuild test robot , , , Subject: Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared Message-ID: <20160914131338.GA9442@uda0271908> Mail-Followup-To: Bin Liu , Tony Lindgren , kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org References: <201606120442.yWatggEa%fengguang.wu@intel.com> <20160908174521.fcrjbcwktfiuujib@atomide.com> <20160908182609.GG4054@uda0271908> <20160913223504.7mdgtipmkltikuyt@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160913223504.7mdgtipmkltikuyt@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote: > * Bin Liu [160908 11:26]: > > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote: > > > --- a/drivers/usb/musb/Kconfig > > > +++ b/drivers/usb/musb/Kconfig > > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX > > > config USB_MUSB_TUSB6010 > > > tristate "TUSB6010" > > > depends on HAS_IOMEM > > > - depends on ARCH_OMAP2PLUS || COMPILE_TEST > > > + depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN > > > > Would this cause more issue later when trying to enable all glue drivers > > in one build? > > Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h.. > It completely redefines all the registers with ifdef else. > > > The macros defined in tusb6010.h are only used in tusb6010.c, so how > > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c > > instead? This gives flexibility to random config test, isn't it? > > I'd like to see that but we have this in musb_core.c: > > hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF; > > So the build would break there again on blackin with tusb6010.. > Got any ideas on how to sort that out? Thanks for catching it. It appears that the glues require more work to cleanup. I am taking your patch. Regards, -Bin. > > Regards, > > Tony