From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1762216AbcINNid (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 09:38:33 -0400
Received: from merlin.infradead.org ([205.233.59.134]:48622 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755879AbcINNib (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 09:38:31 -0400
Date: Wed, 14 Sep 2016 15:38:26 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Riley Andrews <riandrews@android.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@infradead.org>, Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH] android: binder: Disable preemption while holding the
 global binder lock
Message-ID: <20160914133826.GD5020@twins.programming.kicks-ass.net>
References: <CAHRSSEwkj-VxstqCm6JzVQcmZzxLQcob0JNiEhzes9oT0-tXSg@mail.gmail.com>
 <20160910161659.GA7987@infradead.org>
 <20160910162210.GK10153@twins.programming.kicks-ass.net>
 <alpine.DEB.2.20.1609101835360.5560@nanos>
 <20160910172843.GA17876@kroah.com>
 <CAMP5XgfDybsfz-v2NTYqAX8K48xCJ_zkH65AHosAOmT7P=Gyxg@mail.gmail.com>
 <20160913073259.GC5008@twins.programming.kicks-ass.net>
 <CAMP5Xgc89ZONamzB4gmnH3RjW5rDSwh3Akrx30npfTiZ1qGzWg@mail.gmail.com>
 <20160914071001.GI5008@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160914071001.GI5008@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2016 at 09:10:01AM +0200, Peter Zijlstra wrote:
> On Tue, Sep 13, 2016 at 12:53:27PM -0700, Arve Hjønnevåg wrote:

> > Most of the tasks here are not RR/FIFO/DL tasks. I don't see anything
> > in the rtmutex code or documentation that indicates that they don't
> > work for normal tasks. From what I can tell the priority gets boosted
> > in every case. This may not work as well for CFS tasks as for realtime
> > tasks, but it should at least help when there is a large priority
> > difference.
> 
> It does something (it used to explicitly ignore OTHER) but its not
> something well defined or usable.

I looked again, and while it updates the ->prio field for OTHER tasks,
that does not seem to cause a change to the actual weight field (which
is derived from ->static_prio).

So it really should not do anything.. as I remebered it.