From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759121AbcINURG (ORCPT ); Wed, 14 Sep 2016 16:17:06 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33634 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817AbcINURF (ORCPT ); Wed, 14 Sep 2016 16:17:05 -0400 Date: Wed, 14 Sep 2016 13:17:00 -0700 From: Guenter Roeck To: Laura Abbott Cc: Greg-KH , linux-kernel@vger.kernel.org, Sumit Semwal , devel@driverdev.osuosl.org Subject: Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Message-ID: <20160914201700.GD14003@roeck-us.net> References: <1473867238-8801-1-git-send-email-labbott@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473867238-8801-1-git-send-email-labbott@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 08:33:58AM -0700, Laura Abbott wrote: > The Ion platform code uses of_platform_device_create which has > dependencies on OF_ADDRESS. Depending on OF is not sufficient > > Building sparc64:allmodconfig ... failed > -------------- > Error log: > ... > drivers/built-in.o: In function `ion_parse_dt': > (.text+0x11aa2c): undefined reference to `of_platform_device_create' > > Add a dependency on OF_ADDRESS > > Reported-by: Guenter Roeck > Signed-off-by: Laura Abbott Tested-by: Guenter Roeck > --- > Based on next-20160914 > --- > drivers/staging/android/ion/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig > index 8a54ddc..9410554 100644 > --- a/drivers/staging/android/ion/Kconfig > +++ b/drivers/staging/android/ion/Kconfig > @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig" > > config ION_OF > bool "Devicetree support for Ion" > - depends on ION && OF > + depends on ION && OF_ADDRESS > help > Provides base support for defining Ion heaps in devicetree > and setting them up. Also includes functions for platforms > -- > 2.7.4 >